dreampiler/kandev
1
0
Fork 0
Code Issues 43 Pull Requests Actions 6 Packages Projects Releases Wiki Activity

fix(release): use Bash 3.2-safe artifact verifier (#1730)

Browse Source
This commit is contained in:
Carlos Florêncio
2026-07-16 12:31:31 +01:00
committed by GitHub
parent 3952e35c8d
commit c784dfcc91
5 changed files with 69 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/release-desktop.test.sh
+26
View File
@@ -162,6 +162,32 @@ printf 'desktop artifact\n' > "$artifact"
"$ROOT_DIR/scripts/release/verify-desktop-assets.sh" "$assets_dir" linux-x64 >/dev/null
pass "verify-desktop-assets accepts matching checksums"
macos_assets_dir="$TMP_DIR/macos-assets"
mkdir -p "$macos_assets_dir"
macos_artifact="$macos_assets_dir/kandev-desktop-macos-arm64-Kandev.dmg"
printf 'unsigned macOS artifact\n' > "$macos_artifact"
"$ROOT_DIR/scripts/release/write-sha256.sh" \
"$macos_artifact" "$macos_artifact.sha256"
"$ROOT_DIR/scripts/release/verify-desktop-assets.sh" \
"$macos_assets_dir" macos-arm64 >/dev/null
pass "verify-desktop-assets accepts macOS artifacts without optional updater bundles"
missing_assets_dir="$TMP_DIR/missing-assets"
mkdir -p "$missing_assets_dir"
if "$ROOT_DIR/scripts/release/verify-desktop-assets.sh" \
"$missing_assets_dir" macos-arm64 >"$OUT_FILE" 2>"$ERR_FILE"; then
fail "verify-desktop-assets should reject a missing platform artifact"
fi
grep -q "Missing desktop artifact for platform: macos-arm64" "$ERR_FILE" || \
fail "verify-desktop-assets did not explain the missing platform artifact"
pass "verify-desktop-assets reports missing platform artifacts"
if grep -Eq '(artifacts|updater_bundles|updater_signatures)=\(' \
"$ROOT_DIR/scripts/release/verify-desktop-assets.sh"; then
fail "verify-desktop-assets uses optional arrays that fail under Bash 3.2 nounset"
fi
pass "verify-desktop-assets avoids Bash 3.2 empty-array nounset failures"
if signing_secret_env "$ROOT_DIR/scripts/release/desktop-signing-ready.sh" macos >"$OUT_FILE" 2>"$ERR_FILE"; then
fail "desktop-signing-ready should report macOS signing not ready without secrets"
fi