dreampiler/kandev
1
0
Fork 0
Code Issues 43 Pull Requests Actions 6 Packages Projects Releases Wiki Activity

feat(ui): add plugin uninstall confirmations (#2886)

Browse Source
This commit is contained in:
José Almeida
2026-08-22 18:49:55 +00:00
committed by GitHub
parent 39449b8b01
commit c13924b51c
11 changed files with 507 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/e2e/tests/plugins/plugins.spec.ts
+46 -1
View File
@@ -325,7 +325,9 @@ test.describe("Plugins — gRPC plugin install/load/live-update/uninstall", () =
// --- 7. Uninstall via UI (with confirmation): row disappears, package
// directory tree is removed from disk. ---
await pluginRow.getByRole("button", { name: "Uninstall" }).click();
await testPage.getByRole("button", { name: "Confirm uninstall" }).click();
await expect(testPage.getByTestId("plugin-uninstall-confirm-popover")).toContainText("E2E");
await expect(testPage.locator('[data-slot="dialog-overlay"]')).toHaveCount(0);
await testPage.getByTestId("plugin-uninstall-confirm").click();
await expect(pluginRow).toHaveCount(0, { timeout: 10_000 });
const pluginDir = path.join(pluginsDir, PLUGIN_ID);
@@ -383,6 +385,37 @@ test.describe("Plugins — gRPC plugin install/load/live-update/uninstall", () =
await expect(globalToggle).toHaveAttribute("aria-checked", "false");
});
test("row and detail uninstall confirmations stay local to their initiating controls", async ({
testPage,
}) => {
test.setTimeout(60_000);
await openInstallDialog(testPage);
await uploadPackage(testPage, PACKAGE_PATH);
const pluginRow = testPage.getByTestId(`plugin-row-${PLUGIN_ID}`);
await expect(pluginRow).toBeVisible({ timeout: 15_000 });
await pluginRow.getByRole("button", { name: "Uninstall" }).click();
const rowConfirmation = testPage.getByTestId("plugin-uninstall-confirm-popover");
await expect(rowConfirmation).toContainText("Kandev E2E Fixture Plugin");
await expect(testPage.locator('[data-slot="dialog-overlay"]')).toHaveCount(0);
await rowConfirmation.getByRole("button", { name: "Cancel" }).click();
await expect(rowConfirmation).toHaveCount(0);
await pluginRow.click({ position: { x: 600, y: 12 } });
await expect(testPage).toHaveURL(new RegExp(`/settings/plugins/${PLUGIN_ID}$`));
const detail = testPage.getByTestId(`plugin-detail-${PLUGIN_ID}`);
await expect(detail).toBeVisible();
await detail.getByRole("button", { name: "Uninstall" }).click();
const detailConfirmation = testPage.getByTestId("plugin-uninstall-confirm-popover");
await expect(detailConfirmation).toContainText("Kandev E2E Fixture Plugin");
await expect(testPage.locator('[data-slot="dialog-overlay"]')).toHaveCount(0);
await testPage.getByTestId("plugin-uninstall-confirm").click();
await expect(testPage).toHaveURL(/\/settings\/plugins$/);
await expect(testPage.getByTestId(`plugin-row-${PLUGIN_ID}`)).toHaveCount(0);
});
test("shows boot failure diagnostics and retries an errored plugin", async ({
testPage,
apiClient,
@@ -735,6 +768,18 @@ test.describe("Plugins — gRPC plugin install/load/live-update/uninstall", () =
{ timeout: 15_000, intervals: [250, 500, 1000] },
)
.toBe("s3cret-roundtrip");
// --- Uninstall from the detail danger zone: the confirmation stays at
// the initiating control and only successful cleanup returns to the list. ---
await testPage.goto(`/settings/plugins/${PLUGIN_ID}`);
const detail = testPage.getByTestId(`plugin-detail-${PLUGIN_ID}`);
await expect(detail).toBeVisible();
await detail.getByRole("button", { name: "Uninstall" }).click();
await expect(testPage.getByTestId("plugin-uninstall-confirm-popover")).toContainText("E2E");
await expect(testPage.locator('[data-slot="dialog-overlay"]')).toHaveCount(0);
await testPage.getByTestId("plugin-uninstall-confirm").click();
await expect(testPage).toHaveURL(/\/settings\/plugins$/);
await expect(testPage.getByTestId(`plugin-row-${PLUGIN_ID}`)).toHaveCount(0);
});
test("uploading a corrupted package surfaces install-plugin-error", async ({ testPage }) => {