feat(ui): add plugin uninstall confirmations (#2886)

This commit is contained in:
José Almeida
2026-08-22 18:49:55 +00:00
committed by GitHub
parent 39449b8b01
commit c13924b51c
11 changed files with 507 additions and 113 deletions
+28 -3
View File
@@ -45,8 +45,7 @@ vi.mock("@/lib/api/domains/plugins-api", () => ({
return Promise.resolve({ disabled: true });
},
uninstallPlugin: (...args: [string]) => {
uninstallPluginSpy(...args);
return Promise.resolve({ deleted: true });
return uninstallPluginSpy(...args);
},
installPluginFromUrl: (...args: [string]) => installPluginFromUrlSpy(...args),
installPluginUpload: (...args: [File]) => installPluginUploadSpy(...args),
@@ -150,6 +149,7 @@ function emptySyncResult(overrides: Partial<SyncResult> = {}): SyncResult {
}
beforeEach(() => {
uninstallPluginSpy.mockResolvedValue({ deleted: true });
installPluginFromUrlSpy.mockResolvedValue({ plugin: installedPlugin() });
installPluginUploadSpy.mockResolvedValue({ plugin: installedPlugin() });
syncPluginsSpy.mockResolvedValue(emptySyncResult());
@@ -235,7 +235,8 @@ describe("PluginsSettingsPage", () => {
render(<PluginsSettingsPage />);
fireEvent.click(screen.getByRole("button", { name: /uninstall/i }));
fireEvent.click(screen.getByRole("button", { name: /confirm uninstall/i }));
expect(screen.getByTestId("plugin-uninstall-confirm-popover").textContent).toContain("Acme");
fireEvent.click(screen.getByTestId("plugin-uninstall-confirm"));
await vi.waitFor(() => expect(uninstallPluginSpy).toHaveBeenCalledWith(PLUGIN_ID));
expect(unloadPluginSpy).toHaveBeenCalledWith(PLUGIN_ID);
@@ -252,6 +253,30 @@ describe("PluginsSettingsPage", () => {
expect(uninstallPluginSpy).not.toHaveBeenCalled();
});
it("disables auto-update while an uninstall request is pending", async () => {
let resolveUninstall!: (result: { deleted: boolean }) => void;
uninstallPluginSpy.mockReturnValueOnce(
new Promise((resolve) => {
resolveUninstall = resolve;
}),
);
setStoreState([activePlugin({ auto_update: null })]);
render(<PluginsSettingsPage />);
fireEvent.click(screen.getByRole("button", { name: /uninstall/i }));
fireEvent.click(screen.getByTestId("plugin-uninstall-confirm"));
await vi.waitFor(() => expect(uninstallPluginSpy).toHaveBeenCalledWith(PLUGIN_ID));
const autoUpdate = screen.getByTestId(`plugin-auto-update-${PLUGIN_ID}`);
try {
expect((autoUpdate as HTMLButtonElement).disabled).toBe(true);
} finally {
resolveUninstall({ deleted: true });
const removePlugin = storeState.removePlugin as ReturnType<typeof vi.fn>;
await vi.waitFor(() => expect(removePlugin).toHaveBeenCalledWith(PLUGIN_ID));
}
});
});
describe("PluginsSettingsPage install dialog", () => {