feat(web): add global app status surface (#1869)
* feat(web): add app status bar * feat(web): add app status bar visibility toggle * feat(web): persist status bar item order * fix(web): refine app status bar behavior * fix(web): polish app status bar presentation * test(web): split plugin slot coverage groups * fix(web): address status surface review feedback * fix(web): stabilize status bar overlay tests
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
import { AppSidebar } from "@/components/app-sidebar/app-sidebar";
|
||||
import { AppStatusSurfaceProvider } from "@/components/app-status-bar/app-status-surface-provider";
|
||||
import { CommandPanel } from "@/components/command-panel";
|
||||
import { ConfigChatProvider } from "@/components/config-chat/config-chat-provider";
|
||||
import { DiffWorkerPoolProvider } from "@/components/diff-worker-pool-provider";
|
||||
@@ -40,10 +41,12 @@ export function AppShell({ children }: AppShellProps) {
|
||||
<RecentTaskSwitcher />
|
||||
<ConfigChatProvider>
|
||||
<QuickChatProvider>
|
||||
<div className="flex h-screen min-h-0 w-full overflow-hidden">
|
||||
<AppSidebar />
|
||||
<main className="flex-1 min-w-0 min-h-0 flex flex-col">{children}</main>
|
||||
</div>
|
||||
<AppStatusSurfaceProvider>
|
||||
<div className="flex min-h-0 flex-1 overflow-hidden">
|
||||
<AppSidebar />
|
||||
<main className="flex min-h-0 min-w-0 flex-1 flex-col">{children}</main>
|
||||
</div>
|
||||
</AppStatusSurfaceProvider>
|
||||
</QuickChatProvider>
|
||||
</ConfigChatProvider>
|
||||
</CommandRegistryProvider>
|
||||
|
||||
@@ -183,7 +183,7 @@ const SETTINGS_ROUTES: Record<string, RouteRenderer> = {
|
||||
"/settings/system/feature-toggles": () => (
|
||||
<SystemPageShell
|
||||
title="Feature Toggles"
|
||||
description="Enable or disable experimental and diagnostic Kandev features."
|
||||
description="Manage Kandev feature and diagnostic switches."
|
||||
>
|
||||
<FeatureTogglesSettings initialFlags={[]} restartCapability={null} />
|
||||
</SystemPageShell>
|
||||
|
||||
@@ -77,7 +77,9 @@ describe("TaskDetailRoute", () => {
|
||||
|
||||
expect(screen.queryByTestId("kanban-task-shell")).toBeNull();
|
||||
expect(screen.getByRole("status").textContent).toContain("Loading task");
|
||||
expect(screen.getByRole("status").parentElement?.className).toContain("h-dvh");
|
||||
expect(screen.getByRole("status").parentElement?.className).toContain("h-full");
|
||||
expect(screen.getByRole("status").parentElement?.className).toContain("min-h-0");
|
||||
expect(screen.getByRole("status").parentElement?.className).not.toContain("h-dvh");
|
||||
expect(screen.getByRole("status").parentElement?.className).not.toContain("h-screen");
|
||||
|
||||
routeData.resolve(makeFetchedData());
|
||||
|
||||
@@ -80,7 +80,7 @@ export function TaskDetailRoute({
|
||||
|
||||
if (routeState.status === "loading") {
|
||||
return (
|
||||
<div className="flex h-dvh w-full items-center justify-center bg-background">
|
||||
<div className="flex h-full min-h-0 w-full items-center justify-center bg-background">
|
||||
<p role="status" aria-live="polite" className="text-sm text-muted-foreground">
|
||||
Loading task…
|
||||
</p>
|
||||
|
||||
Reference in New Issue
Block a user