dreampiler/kandev
1
0
Fork 0
Code Issues 43 Pull Requests Actions 6 Packages Projects Releases Wiki Activity

chore: strengthen code review prompts (#2267)

Browse Source
This commit is contained in:
Carlos Florêncio
2026-08-05 13:44:25 +01:00
committed by GitHub
parent d54c2effef
commit 9b3aa282a9
7 changed files with 197 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/opencode-code-review.yml
+4
View File
@@ -143,6 +143,8 @@ jobs:
- When needed, inspect nearby files, callers, interfaces, tests, and scoped AGENTS.md files related to patched files.
- Review only the attached patch scope. Do not report unrelated pre-existing issues.
- Report only findings you are at least 80 percent confident about.
- Treat architectural fit as the highest-priority review layer: verify the change is in the correct module and follows dependency direction; domain logic must not move into transport, persistence, or infrastructure layers; and new abstractions must have clear ownership.
- Check data and state modelling: keep domain entities, DTOs, persistence models, and external API models separate when their responsibilities differ; verify explicit invariants, one source of truth, deliberate nullability/defaults, safe retries and partial failures, and backward-compatible contract or schema changes.
- Focus on correctness, security, data loss, missing tests for changed logic, regressions, and architecture violations.
- Avoid style-only feedback and anything linters or typecheckers already catch.
@@ -398,6 +400,8 @@ jobs:
- When needed, inspect nearby files, callers, interfaces, tests, and scoped AGENTS.md files related to patched files.
- Review only the attached patch scope. Do not report unrelated pre-existing issues.
- Report only findings you are at least 80 percent confident about.
- Treat architectural fit as the highest-priority review layer: verify the change is in the correct module and follows dependency direction; domain logic must not move into transport, persistence, or infrastructure layers; and new abstractions must have clear ownership.
- Check data and state modelling: keep domain entities, DTOs, persistence models, and external API models separate when their responsibilities differ; verify explicit invariants, one source of truth, deliberate nullability/defaults, safe retries and partial failures, and backward-compatible contract or schema changes.
- Focus on correctness, security, data loss, missing tests for changed logic, regressions, and architecture violations.
- Avoid style-only feedback and anything linters or typecheckers already catch.