feat(web): collapse mobile task search into a topbar icon (#1157)
This commit is contained in:
@@ -327,6 +327,12 @@ function useKanbanBoardSetup(
|
||||
|
||||
export function KanbanBoard({ onPreviewTask, onOpenTask, onBeforeEdit }: KanbanBoardProps = {}) {
|
||||
const s = useKanbanBoardSetup(onPreviewTask, onOpenTask, onBeforeEdit);
|
||||
const isMobileSearchOpen = useAppStore((state) => state.mobileKanban.isSearchOpen);
|
||||
const setMobileSearchOpen = useAppStore((state) => state.setMobileKanbanSearchOpen);
|
||||
|
||||
// Collapse search on unmount so the global flag doesn't auto-open (and focus)
|
||||
// the search bar after navigating to another route.
|
||||
useEffect(() => () => setMobileSearchOpen(false), [setMobileSearchOpen]);
|
||||
|
||||
if (!s.isMounted) {
|
||||
return <div className="h-dvh w-full bg-background" />;
|
||||
@@ -347,7 +353,7 @@ export function KanbanBoard({ onPreviewTask, onOpenTask, onBeforeEdit }: KanbanB
|
||||
searchQuery={s.searchQuery}
|
||||
onSearchChange={s.setSearchQuery}
|
||||
/>
|
||||
{s.isMobile && (
|
||||
{s.isMobile && isMobileSearchOpen && (
|
||||
<MobileSearchBar searchQuery={s.searchQuery} onSearchChange={s.setSearchQuery} />
|
||||
)}
|
||||
<KanbanBoardDialogs
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
"use client";
|
||||
|
||||
import { Button } from "@kandev/ui/button";
|
||||
import { IconMenu2 } from "@tabler/icons-react";
|
||||
import { IconMenu2, IconSearch } from "@tabler/icons-react";
|
||||
import { PageTopbar } from "@/components/page-topbar";
|
||||
import { MobileMenuSheet } from "./mobile-menu-sheet";
|
||||
import { useAppStore } from "@/components/state-provider";
|
||||
@@ -11,9 +11,7 @@ type KanbanHeaderMobileProps = {
|
||||
currentPage?: "kanban" | "tasks";
|
||||
title: string;
|
||||
workspaceLabel: string;
|
||||
searchQuery?: string;
|
||||
onSearchChange?: (query: string) => void;
|
||||
isSearchLoading?: boolean;
|
||||
showReleaseNotesButton: boolean;
|
||||
onOpenReleaseNotes: () => void;
|
||||
showHealthIndicator: boolean;
|
||||
@@ -25,9 +23,7 @@ export function KanbanHeaderMobile({
|
||||
currentPage = "kanban",
|
||||
title,
|
||||
workspaceLabel,
|
||||
searchQuery = "",
|
||||
onSearchChange,
|
||||
isSearchLoading = false,
|
||||
showReleaseNotesButton,
|
||||
onOpenReleaseNotes,
|
||||
showHealthIndicator,
|
||||
@@ -35,6 +31,15 @@ export function KanbanHeaderMobile({
|
||||
}: KanbanHeaderMobileProps) {
|
||||
const isMenuOpen = useAppStore((state) => state.mobileKanban.isMenuOpen);
|
||||
const setMenuOpen = useAppStore((state) => state.setMobileKanbanMenuOpen);
|
||||
const isSearchOpen = useAppStore((state) => state.mobileKanban.isSearchOpen);
|
||||
const setSearchOpen = useAppStore((state) => state.setMobileKanbanSearchOpen);
|
||||
|
||||
const toggleSearch = () => {
|
||||
const next = !isSearchOpen;
|
||||
setSearchOpen(next);
|
||||
// Clear any active query when collapsing so results aren't filtered by a hidden search.
|
||||
if (!next) onSearchChange?.("");
|
||||
};
|
||||
|
||||
return (
|
||||
<>
|
||||
@@ -44,15 +49,30 @@ export function KanbanHeaderMobile({
|
||||
className="h-10 px-3 py-1"
|
||||
variant={title === "Home" ? "root" : "breadcrumb"}
|
||||
actions={
|
||||
<Button
|
||||
variant="outline"
|
||||
size="icon-lg"
|
||||
onClick={() => setMenuOpen(true)}
|
||||
className="cursor-pointer"
|
||||
>
|
||||
<IconMenu2 className="h-4 w-4" />
|
||||
<span className="sr-only">Open menu</span>
|
||||
</Button>
|
||||
<>
|
||||
{onSearchChange && (
|
||||
<Button
|
||||
variant={isSearchOpen ? "secondary" : "outline"}
|
||||
size="icon-lg"
|
||||
onClick={toggleSearch}
|
||||
className="cursor-pointer"
|
||||
aria-pressed={isSearchOpen}
|
||||
aria-label="Search tasks"
|
||||
data-testid="mobile-search-toggle"
|
||||
>
|
||||
<IconSearch className="h-4 w-4" />
|
||||
</Button>
|
||||
)}
|
||||
<Button
|
||||
variant="outline"
|
||||
size="icon-lg"
|
||||
onClick={() => setMenuOpen(true)}
|
||||
className="cursor-pointer"
|
||||
>
|
||||
<IconMenu2 className="h-4 w-4" />
|
||||
<span className="sr-only">Open menu</span>
|
||||
</Button>
|
||||
</>
|
||||
}
|
||||
/>
|
||||
<MobileMenuSheet
|
||||
@@ -60,9 +80,6 @@ export function KanbanHeaderMobile({
|
||||
onOpenChange={setMenuOpen}
|
||||
workspaceId={workspaceId}
|
||||
currentPage={currentPage}
|
||||
searchQuery={searchQuery}
|
||||
onSearchChange={onSearchChange}
|
||||
isSearchLoading={isSearchLoading}
|
||||
showReleaseNotesButton={showReleaseNotesButton}
|
||||
onOpenReleaseNotes={onOpenReleaseNotes}
|
||||
showHealthIndicator={showHealthIndicator}
|
||||
|
||||
@@ -510,7 +510,7 @@ export function KanbanHeader({
|
||||
currentPage={currentPage}
|
||||
title={title}
|
||||
workspaceLabel={workspaceLabel}
|
||||
{...sharedSearch}
|
||||
onSearchChange={onSearchChange}
|
||||
{...indicatorProps}
|
||||
/>
|
||||
);
|
||||
|
||||
@@ -9,12 +9,13 @@ type MobileSearchBarProps = {
|
||||
|
||||
export function MobileSearchBar({ searchQuery, onSearchChange }: MobileSearchBarProps) {
|
||||
return (
|
||||
<div className="px-4 pb-2" data-testid="mobile-search-bar">
|
||||
<div className="border-b border-border px-4 py-2" data-testid="mobile-search-bar">
|
||||
<TaskSearchInput
|
||||
value={searchQuery}
|
||||
onChange={onSearchChange}
|
||||
placeholder="Search tasks..."
|
||||
className="w-full"
|
||||
autoFocus
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
|
||||
@@ -12,6 +12,7 @@ interface TaskSearchInputProps {
|
||||
debounceMs?: number;
|
||||
isLoading?: boolean;
|
||||
className?: string;
|
||||
autoFocus?: boolean;
|
||||
}
|
||||
|
||||
export function TaskSearchInput({
|
||||
@@ -21,15 +22,24 @@ export function TaskSearchInput({
|
||||
debounceMs = 300,
|
||||
isLoading = false,
|
||||
className,
|
||||
autoFocus = false,
|
||||
}: TaskSearchInputProps) {
|
||||
const [localValue, setLocalValue] = useState(value);
|
||||
const timeoutRef = useRef<NodeJS.Timeout | null>(null);
|
||||
const inputRef = useRef<HTMLInputElement | null>(null);
|
||||
|
||||
// Sync local value when external value changes
|
||||
useEffect(() => {
|
||||
setLocalValue(value);
|
||||
}, [value]);
|
||||
|
||||
// Focus on mount when requested (e.g. when the mobile search bar expands)
|
||||
useEffect(() => {
|
||||
if (autoFocus) {
|
||||
inputRef.current?.focus();
|
||||
}
|
||||
}, [autoFocus]);
|
||||
|
||||
const handleChange = useCallback(
|
||||
(e: React.ChangeEvent<HTMLInputElement>) => {
|
||||
const newValue = e.target.value;
|
||||
@@ -73,6 +83,7 @@ export function TaskSearchInput({
|
||||
<IconSearch className="absolute left-2.5 top-1/2 h-4 w-4 -translate-y-1/2 text-muted-foreground pointer-events-none" />
|
||||
)}
|
||||
<Input
|
||||
ref={inputRef}
|
||||
type="text"
|
||||
value={localValue}
|
||||
onChange={handleChange}
|
||||
|
||||
Reference in New Issue
Block a user