fix: restore sidebar context for missing task routes (#2229)

This commit is contained in:
Carlos Florêncio
2026-08-03 22:24:39 +01:00
committed by GitHub
parent 5772fa86f0
commit 90da2d66f2
15 changed files with 789 additions and 12 deletions
+1
View File
@@ -202,6 +202,7 @@ System pages (Radarr/Sonarr-style) for status, disk usage, database maintenance,
| [workflow-settings-autosave](workflow-settings-autosave/spec.md) | archived; superseded by settings-manual-save |
| [mobile-quick-chat-topbar](mobile-quick-chat-topbar/spec.md) | building |
| [native-code-review](native-code-review/spec.md) | building |
| [missing-task-route-recovery](missing-task-route-recovery/spec.md) | draft |
---
@@ -0,0 +1,86 @@
---
title: Missing task route recovery
status: draft
created: 2026-08-03
owner: kandev
---
# Missing task route recovery
## Problem
A cold navigation to a Kanban task-detail URL whose task is missing, deleted,
or inaccessible renders the intended **Task unavailable** state, but the same
failed task lookup also prevents the app shell from hydrating its authorized
workspace and workflow context. The desktop sidebar therefore reports that
there are no tasks even when the selected workspace contains other tasks, and
the unavailable route offers no direct recovery action on phone viewports where
the desktop sidebar is hidden.
## Desired behavior
- A failed cold load of `/t/:taskId` or the compatibility `/tasks/:taskId`
renders the existing generic unavailable state without revealing whether the
task was deleted, never existed, or is outside the current user's access.
- Failure to load the requested task does not prevent the app shell from
resolving the user's authorized Kanban workspace with the existing explicit
URL parameter, active-workspace cookie, user-setting, and default-workspace
precedence.
- When the resolved workspace contains other visible tasks, the desktop task
sidebar shows them and its rows remain usable navigation targets. The invalid
route ID is not synthesized as a sidebar task.
- The unavailable state includes a visible action back to the task overview for
the resolved workspace. The action is keyboard accessible, touch reachable,
and usable when no workspace can be resolved.
- A valid task-detail boot continues to hydrate from that task's workspace and
does not additionally load or briefly expose fallback workspace data.
- Workspace and task authorization remain unchanged. Fallback state contains
only workspaces, workflows, repositories, and task snapshots already visible
to the current request identity.
- Loading feedback remains visible while the task result is unresolved; the
unavailable state and recovery controls appear only after failure is known.
## Regression scenarios
- **GIVEN** an authorized workspace containing another visible task, **WHEN**
the user cold-loads `/t/<missing-id>`, **THEN** the unavailable state appears,
the desktop sidebar lists the other task instead of **No tasks yet**, and
selecting that row opens the valid task.
- **GIVEN** the active-workspace cookie and user settings identify different
authorized workspaces, **WHEN** a missing task route is cold-loaded, **THEN**
fallback task data comes from the cookie-selected workspace according to the
existing boot precedence.
- **GIVEN** a valid task-detail URL, **WHEN** it is cold-loaded, **THEN** its
route-specific boot data remains authoritative and no fallback workspace
bootstrap is added to the top-level initial state.
- **GIVEN** a user cannot access the requested task but can access another
workspace, **WHEN** the task route loads, **THEN** the generic unavailable
state and only that user's authorized fallback workspace tasks are shown.
- **GIVEN** no Kanban workspace is available, **WHEN** a missing task route
loads, **THEN** the unavailable state remains visible, the sidebar stays
empty, and the task-overview action remains safe to activate.
- **GIVEN** a phone viewport on a missing task route, **WHEN** the unavailable
state renders, **THEN** the task-overview action fits the viewport, has a
touch-sized target, and opens the mobile task overview without relying on the
desktop sidebar.
## Constraints
- The Go-served SPA boot payload remains the first-paint source of workspace
context, consistent with ADRs 0021 and 0023.
- The repair reuses the existing task, workspace, workflow, and snapshot
contracts; it adds no API, persistence, WebSocket, or permission contract.
- Fallback hydration is conditional on unavailable task-detail route data so a
successful task boot does not duplicate its route-specific resource loading.
## Out of scope
- Changing task lookup status codes or disclosing why a task is unavailable.
- Creating a placeholder task for the invalid route ID.
- Redesigning the desktop task sidebar, task switcher, or Kanban overview.
- Changing Office task-detail not-found behavior under `/office/tasks/:id`.
- Retrying backend failures beyond the existing task-detail client retry.
## Implementation plan
- [Missing task route recovery](../../plans/missing-task-route-recovery/plan.md)