From 84a9ca08225f34a7d9d0423cb401cdcc112b995a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Flor=C3=AAncio?= Date: Sun, 19 Jul 2026 22:09:49 +0100 Subject: [PATCH] fix: ignore echoed user ACP chunks (#1804) --- .../agent/runtime/lifecycle/manager_events.go | 2 +- .../runtime/lifecycle/manager_events_test.go | 29 +++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/apps/backend/internal/agent/runtime/lifecycle/manager_events.go b/apps/backend/internal/agent/runtime/lifecycle/manager_events.go index e4f493e74b..14f8fb25a7 100644 --- a/apps/backend/internal/agent/runtime/lifecycle/manager_events.go +++ b/apps/backend/internal/agent/runtime/lifecycle/manager_events.go @@ -21,7 +21,7 @@ const ( // handleMessageChunkEvent handles a "message_chunk" agent event, accumulating and flushing on newlines. func (m *Manager) handleMessageChunkEvent(execution *AgentExecution, event agentctl.AgentEvent) { - if event.Text == "" { + if event.Role == "user" || event.Text == "" { return } execution.messageMu.Lock() diff --git a/apps/backend/internal/agent/runtime/lifecycle/manager_events_test.go b/apps/backend/internal/agent/runtime/lifecycle/manager_events_test.go index 9f62a19d7b..bae65f7e46 100644 --- a/apps/backend/internal/agent/runtime/lifecycle/manager_events_test.go +++ b/apps/backend/internal/agent/runtime/lifecycle/manager_events_test.go @@ -87,6 +87,35 @@ func createTestExecution(id, taskID, sessionID string) *AgentExecution { } } +func TestHandleAgentEvent_UserMessageChunkNotBufferedAsAssistant(t *testing.T) { + mgr, eventBus := createTestManagerWithTracking() + execution := createTestExecution("exec-1", "task-1", "session-1") + if err := mgr.executionStore.Add(execution); err != nil { + t.Fatalf("add execution: %v", err) + } + + mgr.handleAgentEvent(execution, agentctl.AgentEvent{ + Type: "message_chunk", + Text: "\nhello", + Role: "user", + }) + mgr.handleAgentEvent(execution, agentctl.AgentEvent{ + Type: "message_chunk", + Text: "Hello.", + }) + mgr.handleAgentEvent(execution, agentctl.AgentEvent{Type: "complete"}) + + var streamedText string + for _, event := range eventBus.getStreamEvents() { + if event.Data != nil && event.Data.Type == "message_streaming" { + streamedText += event.Data.Text + } + } + if streamedText != "Hello." { + t.Fatalf("streamed assistant text = %q, want %q", streamedText, "Hello.") + } +} + // TestHandleAgentEvent_StreamingThenComplete tests the normal flow: // message_chunk events followed by complete event - should NOT create duplicate func TestHandleAgentEvent_StreamingThenComplete(t *testing.T) {