feat(vcs): add commit body field and AI generation for commit description and PR title (#465)

* feat(vcs): add commit body/description field to commit dialog

Add an optional description textarea below the commit title in both
desktop and mobile commit dialogs, with a dedicated AI generate button
for the description. Add builtin-commit-description utility agent and
E2E test.

* style: fix prettier formatting in mobile git controls and E2E test

* fix(e2e): use specific testid selectors for commit dialog inputs

The commit dialog now has two textboxes (title + body), so
getByRole("textbox") is ambiguous. Use getByTestId selectors
and add exact match for the Commit button.

* fix(ui): add cursor-pointer to mobile commit button

* fix(ui): remove "(optional)" from description label and "Generate" text from button

* fix(ui): match PR dialog style for commit description generate button

* feat(vcs): add AI generate button for PR title

Add builtin-pr-title utility agent and wire up a generate button
inside the PR title input, matching the commit title pattern.
Extract shared dialog field components into vcs-dialog-fields.tsx
to stay within the 600-line file limit.

* refactor(ui): unify generate buttons as icon-only sparkles inside inputs

Move AI generate buttons inside both title inputs and description
textareas (top-right corner) for a consistent look. Remove the
"Generate" label variant — all buttons are now icon-only sparkles.

* style: fix prettier formatting in utility agent generator hook

* fix(a11y): add aria-labels to generate buttons and PR title input

* ci: retrigger E2E tests

* fix(e2e): improve commit dialog button click reliability

Add exact match and enabled check before clicking the dialog
Commit button, increase close timeout.

* ci: retrigger checks

* fix(e2e): improve pre-hooks test commit button reliability

Add exact match, enabled check, and longer dialog timeout to match
the commit-body test pattern.

* fix(ui): prevent dialog field overflow and improve commit description prompt

- Add min-w-0 to relative wrappers in commit and PR dialog fields to
  prevent text inputs/textareas from overflowing the dialog bounds
- Rewrite commit description prompt to use system-role framing that
  prevents weaker models from adding conversational preamble
This commit is contained in:
José Almeida
2026-03-26 13:24:30 +00:00
committed by GitHub
parent ec01a55354
commit 7d900fea91
7 changed files with 620 additions and 167 deletions
@@ -132,9 +132,11 @@ test.describe("Git commit pre-hooks", () => {
// Fill commit message and submit
const dialog = testPage.getByRole("dialog");
await expect(dialog).toBeVisible({ timeout: 5_000 });
await dialog.getByRole("textbox").fill("test commit message");
await dialog.getByRole("button", { name: "Commit" }).click();
await expect(dialog).toBeVisible({ timeout: 10_000 });
await dialog.getByTestId("commit-title-input").fill("test commit message");
const dialogCommitBtn = dialog.getByRole("button", { name: "Commit", exact: true });
await expect(dialogCommitBtn).toBeEnabled();
await dialogCommitBtn.click();
// The error message should appear in the chat
await expect(session.gitOperationErrorMessage()).toBeVisible({ timeout: 30_000 });