From 6271fc37ed1e6c25710a85ea567e5b7cf73ef3eb Mon Sep 17 00:00:00 2001 From: Henry Date: Mon, 31 Aug 2026 21:05:02 +0000 Subject: [PATCH] chore(agentctl): remove ApprovalPolicy field that never governed approval (#3209) Co-authored-by: nova28 <17953305+nova28@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 Co-authored-by: Carlos Florencio --- apps/backend/internal/agentctl/server/adapter/adapter.go | 6 ------ .../agentctl/server/adapter/transport/shared/config.go | 9 --------- apps/backend/internal/agentctl/server/process/manager.go | 1 - 3 files changed, 16 deletions(-) diff --git a/apps/backend/internal/agentctl/server/adapter/adapter.go b/apps/backend/internal/agentctl/server/adapter/adapter.go index d47d43fdb7..734dced1ad 100644 --- a/apps/backend/internal/agentctl/server/adapter/adapter.go +++ b/apps/backend/internal/agentctl/server/adapter/adapter.go @@ -259,11 +259,6 @@ type Config struct { // AutoApprove automatically approves permission requests AutoApprove bool - // ApprovalPolicy controls when the agent requests approval. - // Valid values: "untrusted" (always), "on-failure", "on-request", "never". - // Defaults to "on-request" if empty. - ApprovalPolicy string - // McpServers is a list of MCP servers to configure for the agent McpServers []McpServerConfig @@ -323,7 +318,6 @@ func (c *Config) ToSharedConfig() *shared.Config { return &shared.Config{ WorkDir: c.WorkDir, AutoApprove: c.AutoApprove, - ApprovalPolicy: c.ApprovalPolicy, McpServers: mcpServers, AgentID: c.AgentID, AgentName: c.AgentName, diff --git a/apps/backend/internal/agentctl/server/adapter/transport/shared/config.go b/apps/backend/internal/agentctl/server/adapter/transport/shared/config.go index 47b4d98512..3984bc22d6 100644 --- a/apps/backend/internal/agentctl/server/adapter/transport/shared/config.go +++ b/apps/backend/internal/agentctl/server/adapter/transport/shared/config.go @@ -14,15 +14,6 @@ type Config struct { // AutoApprove automatically approves permission requests AutoApprove bool - // ApprovalPolicy controls when the agent requests approval. - // Valid values: "untrusted" (always), "on-failure", "on-request", "never". - // Defaults to "on-request" if empty. - ApprovalPolicy string - - // PermissionPolicy controls the permission mode: "autonomous", "supervised", "plan". - // Used to determine hook registration and --permission-mode flag. - PermissionPolicy string - // PermissionTimeout is the maximum time to wait for a permission response. // After timeout, the request is auto-denied with interrupt. Defaults to DefaultPermissionTimeout. PermissionTimeout time.Duration diff --git a/apps/backend/internal/agentctl/server/process/manager.go b/apps/backend/internal/agentctl/server/process/manager.go index 8ee8c8570d..3c0be18ae7 100644 --- a/apps/backend/internal/agentctl/server/process/manager.go +++ b/apps/backend/internal/agentctl/server/process/manager.go @@ -1340,7 +1340,6 @@ func (m *Manager) buildAdapterConfig() error { m.adapterCfg = &adapter.Config{ WorkDir: m.cfg.WorkDir, AutoApprove: m.cfg.AutoApprovePermissions, - ApprovalPolicy: m.cfg.ApprovalPolicy, McpServers: mcpServers, AgentID: m.cfg.AgentType, // From registry (e.g., "auggie", "amp", "claude-code") AssumeMcpSse: m.cfg.AssumeMcpSse,