feat(ui): standardize responsive control sizing (#3563)

This commit is contained in:
Carlos Florêncio
2026-09-10 18:14:05 +01:00
committed by GitHub
parent 8b64aed179
commit 5ffbda61a9
245 changed files with 2862 additions and 824 deletions
+137
View File
@@ -0,0 +1,137 @@
---
created: 2026-09-09
status: complete
requirements:
- REQ-UI-CONTROL-SIZING-001
system_design:
- ../../specs/ui/system-design/control-sizing.md
legacy_specs: []
---
# Implementation plan: Consistent control sizing
## Overview
Standardize ordinary desktop controls around the Start Task dialog.
Establish shared size classes first, then migrate task, settings, and remaining
application surfaces. Each migration preserves touch targets and interactions.
The user accepted the 28px standard, the 24px compact exception, and a broader sweep.
The UI system owns the reusable geometry contract.
Production implementation and focused browser verification are complete.
## Scope
### In scope
- Shared buttons, single-line inputs, select triggers, combobox triggers, and attached icon actions.
- Task details, task creation, settings, integrations, navigation, Office, and shared application wrappers.
- The [candidate inventory](sweep-inventory.md), plus helper, CSS, size-prop, and padding-only follow-up searches.
- Skill guidance and scoped frontend instructions for future control changes.
- Rendered desktop dimensions, touch minimums, and representative interaction checks.
### Out of scope
- Changes to task or provider state, APIs, permissions, or persistence.
- Uniform heights for selection cards, multiline fields, menu options, and third-party editors.
- A new user density preference or a global CSS override for every button.
## Root cause and evidence
The completed-session action combines small Button size with unconditional
`min-h-11`. CSS minimum height forces 44px on desktop.
Recovery actions repeat the same pattern. Other pages use unrelated 24px,
32px, and 36px sizes for equivalent actions.
Settings helpers only set a desktop minimum. Explicit larger heights still win.
The existing desktop typography test checks only a lower bound, so it accepts
oversized controls.
The initial AST scan examined 1,526 TSX source files and found 681 candidate
attributes across 315 files. These counts include correct responsive controls.
The completed inventory records each candidate's source-backed disposition.
The implementation adds representative unit and rendered geometry coverage.
## Technical approach
The [system design](../../specs/ui/system-design/control-sizing.md) defines shared class ownership and responsive behavior.
The existing primitive APIs retain their specialized variants.
Ordinary call sites use the default size.
Application wrappers consume one shared adaptive sizing source.
Each sweep work order owns every file in its inventory section.
Every candidate receives a disposition: changed, already conforming,
touch-only, content-sized, or documented exception.
Implementation must include additional files found through helper and CSS searches.
No candidate remains silently excluded at completion.
## Tests
- Shared size composition: `apps/web/lib/ui/control-sizing.test.tsx`.
- Task behavior: existing `session-stopped-banner.test.tsx` and
`task-create-dialog-footer.test.ts`.
- Settings helper behavior: existing `settings-typography.test.ts`.
- Browser geometry remains authoritative. Unit class assertions cannot prove rendered heights.
## E2E tests
| Work order | Evidence | Criteria |
| --- | --- | --- |
| 01 | Shared baseline in `layout/control-sizing.spec.ts` and `layout/mobile-control-sizing.spec.ts` | .1-.5, .9 |
| 02 | `task/control-sizing.spec.ts` and `task/mobile-control-sizing.spec.ts` | .1-.10 |
| 03 | `settings/control-sizing.spec.ts`, mobile pair, and existing Layouts/typography specs | .1-.10 |
| 04 | Extend layout pair across integration, Office, navigation, and retained exceptions | .1-.10 |
All criterion suffixes refer to `AC-UI-CONTROL-SIZING-001`.
Use existing managed fixtures and rebuild through the managed E2E runner.
Include 390px and 700px phones, 900px coarse-pointer tablet, and fine-pointer desktop.
Assertions cover exact desktop size, same-row equality, touch minimums, and action results.
## Work orders
- [x] [Task 01: Shared control sizes](task-01-shared-sizes.md)
- [x] [Task 02: Task control sweep](task-02-task-controls.md)
- [x] [Task 03: Settings control sweep](task-03-settings-controls.md)
- [x] [Task 04: Application control sweep](task-04-application-controls.md)
Work proceeds sequentially. No delegation is authorized.
## Instruction changes
The planning turn updates mobile-parity, its mobile reference, the E2E skill,
and the scoped frontend engineering guide. The new sizing reference records
the sweep procedure and regression expectations.
## Verification results
Artifact checks passed on 2026-09-09:
- `python3 scripts/lint-harness-files.test.py`: 19 tests passed.
- `python3 .github/scripts/lint-harness-files.py --all`: all 187 harness files passed.
- `python3 scripts/lint-spec-files.test.py`: 30 tests passed.
- `python3 scripts/lint-spec-files.py --all`: all specifications passed.
- `git diff --check`: passed.
Production and browser verification completed on 2026-09-10.
Each work order records its own red/green commands and results.
Final verification summary:
- `pnpm --dir apps install --frozen-lockfile`: passed.
- Focused Vitest: 9 files, 111 tests passed.
- Managed E2E: layout 3 desktop and 2 mobile, task 4 desktop and 1 mobile,
settings 10 desktop and 8 mobile, plus the task workflow-stepper pair, all passed.
- Exact changed-file ESLint covered 200 `apps/web` TypeScript files with 0 errors
and 7 non-blocking warnings.
- Harness and specification validation passed: 19 harness tests, 187 harness
files, 30 specification tests, all specifications, targeted pre-commit harness
lint, and `git diff --check`.
## Risks
- A minimum height can override a smaller explicit height.
- SelectTrigger data-size variants can override ordinary height classes.
- Attached clear/reveal controls can overlap after only the field shrinks.
- Shared wrappers can affect compact chrome or mobile-only surfaces.
- Long translations and coarse-pointer input fonts can expose clipping.
- The AST candidate list does not resolve named constants or runtime branches.
@@ -0,0 +1,441 @@
# Control sizing sweep inventory
## Status and method
Snapshot: 2026-09-10. Production implementation is complete.
A read-only TypeScript AST scan examined 1526 TSX source files under
`apps/web/components`, `apps/web/app`, and `apps/packages/ui/src`.
It found 681 candidate attributes across 315 files.
The scan inspected button-like tags, Inputs, SelectTriggers, Comboboxes,
CommandInputs, and dialog actions for explicit height classes and large sizes.
These are candidates, not 681 confirmed bugs.
Responsive branches, content-sized rows, and correct touch-only controls also match.
The scan does not resolve named class constants or inherited geometry.
It does not establish which components mount in each viewport.
Every listed candidate has an inspected control and one final disposition. A checked box records source review and, where the control is covered by a representative flow, rendered evidence. Follow-up helper, CSS, size-prop, and padding-only findings are listed in the additional implementation section.
## Confirmed starting points
| Source | Evidence | Intended correction |
| --- | --- | --- |
| `task/chat/session-stopped-banner.tsx` | Three actions use unconditional min-h-11 | Standard desktop height plus scoped touch minimum |
| `task/chat/dynamic-route-recovery.tsx` | Retry/skip/cancel/stop share unconditional min-h-11 | Standard desktop actions |
| `settings/layouts/layout-profile-list.tsx` | Action wrapper uses sm:min-h-8 | Standard desktop actions |
| `settings/layouts/layout-settings.tsx` | Input uses sm:min-h-9 and actions use sm:min-h-8 | Aligned standard fields/actions |
| `settings/workspaces/workspace-settings-shell.tsx` | Heading picker overrides h-9 | Standard trigger height |
| `settings/workflow-section-actions.tsx` | Ordinary toolbar actions use size=sm | Standard ordinary actions |
| `settings/repository-secret-bindings.tsx` | Inputs/selects/actions use unconditional 44px classes | Aligned desktop group and touch targets |
| `settings/system/storage/storage-action-button.tsx` | Button and disabled wrapper impose min-h-11 | Shared standard dimensions |
| `settings/system/storage/storage-policy-fields.tsx` | settingsControlClassName receives h-11 | Remove caller override |
| `settings/system/storage/storage-adoption-field.tsx` | Input uses h-11 | Standard field |
| `settings/settings-control.ts` | Only a desktop minimum constrains callers | Shared complete sizing contract |
| `task/workflow-step-disclosure.tsx` | Move here already uses h-7 and coarse h-11 | Preserve action sizing and inspect row spacing |
Paths in this table are relative to `apps/web/components`.
The table includes helper files outside the AST candidate list.
## Complementary search
```bash
rg -n '(min-h-|max-h-|h-|size-)(8|9|10|11|12|\[)|size="(sm|lg)"|height\s*:' \
apps/web/components apps/web/app apps/packages/ui/src \
-g '*.tsx' -g '*.ts' -g '*.css' -g '!*.test.*'
rg -n 'settingsControlClassName|settingsActionClassName|touchButtonClass|buttonVariants|triggerClassName' \
apps/web/components apps/web/app apps/packages/ui/src
```
Inspect padding-only raw buttons, wrappers, flex stretching, and data-size selectors separately.
Repeat these searches after each migration family.
Do not mechanically replace every result.
## Disposition key
- **changed in implementation:** the candidate was migrated to the shared standard or compact contract.
- **already conforming:** the candidate already receives the correct role from a shared primitive.
- **touch-only:** the candidate is intentionally a touch composition.
- **content-sized:** the candidate is a content surface such as a row, card, menu, chip, or picker option.
- **documented exception:** the candidate is specialized chrome covered by the system design exceptions.
## Shared primitives
- [x] `apps/packages/ui/src/sidebar.tsx` — documented exception; specialized chrome retains independent geometry.
## Task surfaces
- [x] `apps/web/components/task-create-dialog-advanced-settings.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-create-dialog-dependencies.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-create-dialog-footer.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task-create-dialog-launch-preview-control.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task-create-dialog-pill.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-create-dialog-priority-select.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task-create-dialog-remote-repo-chip.tsx` — chip surface remains content-sized; embedded retry action uses the standard adaptive control size.
- [x] `apps/web/components/task-create-dialog-repo-chip-parts.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task-create-dialog-repository-sets-control.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-create-dialog-source-mode.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-create-dialog-workspace-repo-chips.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/add-workspace-sources/add-folder-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/add-workspace-sources/add-workspace-sources-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/branch-picker-list.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/changes-panel-dialogs.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/anchored-last-prompt-bar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/chat-input-toolbar-mobile.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/chat-input-toolbar-primitives.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/clarification-overlay-header.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/clarification-panel-section.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/clarification-status-banner.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/context-items/context-chip.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/dynamic-route-recovery.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/chat/entity-reference-menu.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/mcp-explorer/mcp-explorer-header.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/mcp-explorer/mcp-indicator.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/mcp-explorer/mcp-server-list.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/mcp-explorer/mcp-tool-detail.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/mcp-explorer/mcp-tool-list.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/message-list-shared.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/messages/action-message-actions.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/chat/messages/action-message-recovery.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/chat/messages/agent-status.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/messages/kandev/rich-output/chart-block.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/chat/messages/kandev/rich-output/file-preview-block.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/chat/messages/message-comment-surface.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/messages/prompt-mention-components.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/messages/tool-subagent-message.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/popup-menu.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/queued-ghost-list.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/queued-ghost-message.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/queued-ghost-panel-header.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/queued-ghost-row-actions.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/chat/reset-context-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/scroll-to-last-prompt-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/chat/session-stopped-banner.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/commit-detail-panel.tsx` — panel surface remains content-sized; embedded retry action uses the standard adaptive control size.
- [x] `apps/web/components/task/ensure-session-error.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/executor-environment-info.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/executor-settings-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/file-browser-parts.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/file-browser-toolbar.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/file-upload-conflict-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/file-viewer-header.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/html-preview-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/markdown-preview-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/mobile/mobile-file-viewer-panel.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/mobile-pill-button.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/mobile-terminal-keybar-helpers.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/mobile-terminal-row.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/plugin-panel-picker.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/session-mobile-bottom-nav.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/session-mobile-top-bar.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mobile/session-task-switcher-sheet.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/task/mode-selector.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/passthrough-toolbar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/port-forward-dialog-actions.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/port-forward-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/preview-plan-panel.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/prompt-history-panel-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/prompt-history-panel-row.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/remote-cloud-tooltip.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/remote-contribution-header-actions.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/remote-contribution-resolution-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/review-item-selector.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/session-dialog-shared.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/sessions-dropdown.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/sidebar-filter/automatic-color-repository-picker.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/sidebar-filter/automatic-color-rule-card.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/sidebar-filter/automatic-color-rule-fields.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/sidebar-filter/automatic-color-settings.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/sidebar-filter/sidebar-filter-bar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/sidebar-filter/sidebar-settings-disclosure.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/sidebar-filter/sidebar-view-chips.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/sidebar-filter/sort-picker-primitive.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/sidebar-filter/task-row-settings.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/sidebar-filter/typed-filter-clause-editor.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/sidebar-filter/view-manager.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/simple/OfficeSimplePane.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/simple/components/labels-picker.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/simple/components/managed-runtime-npm-run-error.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/simple/components/multi-select-popover.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/simple/components/run-error-entry.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/simple/components/task-launch-error-entry.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/task-page-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/task-pr-picker-dialog.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/task/task-unarchive-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task/workflow-step-disclosure.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/workspace-switcher.tsx` — already conforming; retained after source and responsive-geometry review.
## Settings surfaces
- [x] `apps/web/app/settings/agents/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executor/[id]/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executor/[id]/profile/[profileId]/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/k8s/[executorId]/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/new/[type]/kubernetes-create-page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/new/[type]/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/new/[type]/ssh-create-page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/executors/ssh/[executorId]/page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/workspace/workspace-repositories-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/app-sidebar/sections/settings/settings-search.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/account/security-settings.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/settings/agent-profile-delete-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/agent-profile-page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/agent-profile-picker.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/settings/agent-runtime-update-control.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/agents/agent-profiles-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/canvas-host-components.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/canvas-lifecycle-dialogs.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/cli-flags-field.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/copy-move-dialog-body.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/dynamic-agent-candidate-list.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/dynamic-agent-policy-editor.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/dynamic-agents-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/executor-profiles-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/installed-agent-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/keyboard-shortcuts-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/layouts/layout-editor-toolbar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/layouts/layout-profile-delete-confirmation.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/layouts/layout-profile-list.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/layouts/layout-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/mcp-strategy-select.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/settings/model-config-resolution-status.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/model-fallback-settings-shell.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/settings/notification-events-table.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/settings/notifications-settings-external-providers.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/plugins/marketplace-sources-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/plugins/plugin-detail.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/plugins/plugin-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-advanced-options.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/settings/profile-edit/env-vars-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-edit/inline-secret-select.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-edit/portable-config-bundles.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-edit/profile-connection-settings-action.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-edit/profile-edit-page-chrome.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-enabled-help.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/profile-status-panels.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/prompt-row-actions.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/repository-branch-policies.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/repository-branch-policy-fields.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/repository-secret-bindings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/runtime-version-picker.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/secrets-delete-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/secrets-list-item-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/settings-floating-save.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/sleep-inhibition-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/bundle-customizer.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/feature-toggles-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/log-viewer.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/message-queue-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/storage/storage-action-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/storage/storage-adoption-field.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/storage/storage-confirmation-dialogs.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/storage/storage-policy-fields.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/storage/storage-setting-help.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/settings/units/unit-members-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-cycle-diagnostic.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-pipeline-editor-panels.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-pipeline-editor-step-actions.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-pipeline-editor-wip-controls.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-pipeline-editor.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-session-config-carry-warning.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-session-config-editor.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-session-config-rule-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-step-agent-profile-selector.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/settings/workspace-canvases-page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workspaces/workspace-placement-card.tsx` — changed in implementation; verified by source review and focused checks.
## Office surfaces
- [x] `apps/web/app/office/agents/[id]/components/agent-configuration-tab.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/inbox/inbox-page-client.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/projects/[id]/project-header.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/projects/create-project-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/projects/project-repository-picker.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/routines/routine-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/setup/close-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/setup/step-agent.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/tasks/[id]/advanced-panels/chat-panel.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/activity/activity-feed.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/costs/create-budget-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/org/org-zoom-controls.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/routing/components/role-tier-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/settings/export/export-file-tree.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/workspace/skills/skill-list.tsx` — changed in implementation; verified by source review and focused checks.
## Other application surfaces
- [x] `apps/web/app/gitlab/gitlab-page-client.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/app/tasks/tasks-list-controls.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/tasks/tasks-list-view.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/tasks/tasks-pagination.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/app-sidebar/app-sidebar-section.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/app-status-bar/agent-runtime-unavailable-alert.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/app-status-bar/app-status-surface-provider.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/app-status-bar/backend-reload-required-alert.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/automations/automation-delete-confirm-dialog.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/automations/automations-export-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/automations/automations-list-page.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/automations/schedule-selector.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-board.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-default-queries.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-quick-actions.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-watch-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/azure-devops/azure-devops-work-item-detail.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/branch-refresh-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/canvas/canvas-task-create-launcher.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/combobox.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/command-panel-footer.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/command-panel-scope-switcher.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/config-chat/config-chat-panel.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/config-chat/config-chat-setup.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/confirmation/action-confirm-popover.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/create-local-repository-surface.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/editors/codemirror/codemirror-code-editor.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/editors/lsp-status-button.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/editors/monaco/monaco-editor-toolbar.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/editors/tiptap/plan-bubble-menu.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/enhance-prompt-button.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/folder-picker.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/github/action-presets-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/default-queries-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-access-help.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-connection-panel.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-create-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-import-fields.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-import-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-import-guide.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-app-policy-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-cli-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-connection-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-connection-settings-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-pat-form.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-permissions-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-repo-scope-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/github-status.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/multi-pr-ci-popover.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/github/my-github/presets-sidebar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/github/pr-ci-automation-rows.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/github/pr-merge-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/pr-reviews-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/action-presets-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/mr-detail-panel.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/mr-discussions-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/mr-reviewer-control.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/my-gitlab/list-toolbar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/my-gitlab/presets-sidebar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/gitlab/subscription-toggle.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/watch-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/gitlab/watch-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/change-request-ci-anatomy.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/integrations/change-request-detail-comments.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/integrations/change-request-detail-copy-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/change-request-detail-header.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/change-request-detail.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/integration-change-request-status-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/integrations/integration-change-request-status-mobile.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/integrations/integration-change-request-status-trigger.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/integrations/integration-list-toolbar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/integration-save-query-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/integration-start-task-menu.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/saved-query-default-button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/validated-popover.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/jira/jira-action-bar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/jira/jira-oauth-fields.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/jira/my-jira/list-toolbar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/jira/task-presets-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/kanban-card-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/kanban/columns-menu.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/kanban/graph2-task-pipeline.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/kanban/kanban-header.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/kanban/mobile-column-tabs.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/kanban/mobile-menu-task-list-options.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/kanban/mobile-menu-utility-actions.tsx` — touch-only; preserved with its existing touch composition.
- [x] `apps/web/components/linear/linear-settings.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/model-config-selector-content.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/navigation/app-nav-sections.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/navigation/app-nav-trigger.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/navigation/destination-rows.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/quick-chat/quick-chat-dialog.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/quick-chat/quick-chat-setup.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/quick-chat/quick-chat-tab-item.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/quick-chat/quick-chat-tab-strip.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/quick-chat/quick-tab-add-menu.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/quick-chat/quick-terminal-tab-item.tsx` — documented exception; specialized chrome retains independent geometry.
- [x] `apps/web/components/repository-discovery-root-controls.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/review/review-dialog-pr-state.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/review/review-diff-header.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/review/review-diff-toolbar.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/review/walkthrough-overlay.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/runs/automation-detail-page.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/runs/run-filters.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/sentry/sentry-instance-card.tsx` — card surface remains content-sized; embedded Edit and Delete actions use the standard adaptive control size.
- [x] `apps/web/components/sentry/sentry-issue-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/sentry/sentry-issue-watch-multiselect.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/session/prepare-progress.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/shared/resizable-markdown-table.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/system-health/health-indicator.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task-autopilot-toggle.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task-edit-dialog-dependencies.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/task-preview-panel.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/theme-toggle.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/threads/thread-session-switcher.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/threads/threads-view-controls.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/threads/threads-view-editor-actions.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/threads/threads-view-editor-sections.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/threads/threads-view-task-picker.tsx` — content-sized; preserved because the surface is not an ordinary control.
- [x] `apps/web/components/ui/data-table-pagination.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/watches/watcher-delete-action.tsx` — already conforming; retained after source and responsive-geometry review.
- [x] `apps/web/components/workflow-selector-row.tsx` — changed in implementation; verified by source review and focused checks.
## Additional implementation files
Follow-up helper, size-prop, and padding-only searches identified these implementation files outside the original AST rows. Each changed row is included here so the final sweep remains auditable.
- [x] `apps/packages/ui/src/button.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/packages/ui/src/control-sizing.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/packages/ui/src/input-group.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/packages/ui/src/input.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/packages/ui/src/select.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/agents/agents-page-client.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/components/new-task-bottom-bar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/components/new-task-participant-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/components/new-task-selector-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/components/new-task-stages.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/components/routing/route-panel.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/office/setup/step-tier-profiles.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/workspace/workspace-repositories-client.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/workspace/workspace-repository-set-editor.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/workspace/workspace-repository-sets-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/settings/workspace/workspaces-page-client.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/app/tasks/columns.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/my-github/issue-list.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/my-github/list-toolbar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/github/my-github/save-preset-dialog.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/auth-error-message.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/integrations/integration-cursor-pagination.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/jira/my-jira/ticket-row.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/settings-control.ts` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/settings-typography.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/system/feature-toggle-card.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-section-actions.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workflow-sync-section.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/settings/workspaces/workspace-settings-shell.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/remediation-link.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/sidebar-filter/filter-multi-select.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/sidebar-filter/group-picker.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/simple/task-documents.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/task/task-top-bar.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/components/workspaces/workspace-picker-content.tsx` — changed in implementation; verified by source review and focused checks.
- [x] `apps/web/lib/utils/selector-options.ts` — changed in implementation; verified by source review and focused checks.
## Completion evidence
Implementation completed on 2026-09-10.
- Shared primitives now own the 28px standard, 24px compact, and responsive coarse-pointer touch classes.
- Ordinary task, settings, integration, Office, navigation, and shared-wrapper controls were migrated; retained rows identify content-sized, touch-only, or documented specialized geometry.
- Red/green regressions covered shared controls, completed-session actions, task creation, Layouts, repository secrets, workflow navigation, settings typography, and representative application controls.
- Final focused Vitest and managed E2E results are recorded in the work orders and plan.
- The final source sweep found no unexplained ordinary control with an unconditional desktop 44px height; remaining explicit heights are classified above or are embedded/editor/layout geometry.
@@ -0,0 +1,124 @@
---
id: "01-shared-sizes"
title: "Shared control sizes"
status: complete
wave: 1
depends_on: []
plan: "plan.md"
requirements:
- REQ-UI-CONTROL-SIZING-001
acceptance_criteria:
- AC-UI-CONTROL-SIZING-001.1
- AC-UI-CONTROL-SIZING-001.2
- AC-UI-CONTROL-SIZING-001.3
- AC-UI-CONTROL-SIZING-001.4
- AC-UI-CONTROL-SIZING-001.5
- AC-UI-CONTROL-SIZING-001.9
system_design:
- ../../specs/ui/system-design/control-sizing.md
---
# Task 01: Shared control sizes
## Summary
Introduce the shared dimension classes and align the primitive/application-wrapper boundary. Preserve existing primitive size meanings and native input attributes.
## In scope
- Add apps/packages/ui/src/control-sizing.tsx and use it in Button, Input, SelectTrigger, and the single-line InputGroup shell.
- Align settings-control helpers, Combobox triggers, and workspace triggers with the shared dimensions.
- Apply adaptive touch sizing explicitly to ordinary control wrappers. Preserve specialized primitive consumers.
- Establish reusable browser geometry assertions in apps/web/e2e/helpers/control-sizing.ts and the layout spec pair.
## Out of scope
- Feature state, callbacks, permission changes, and persistence.
- Unrelated theme, typography, or navigation redesign.
## Acceptance
- Standard and compact size composition preserves the existing public props and native Input size attribute.
- Real Start Task and Appearance controls meet desktop and touch dimensions, including attached actions.
- The shared code introduces no global selector that resizes every button.
## Regression first
Add a rendered test for the Appearance selector on the existing 900px coarse-pointer tablet fixture.
Confirm that its current desktop height fails the 44px touch minimum.
Also compare ordinary desktop controls with the Start Task action.
Use TDD for new helper logic and browser regressions.
Run the new regression before production edits and record the expected failure.
Rerun the same check after the correction.
## Verification
Run from the repository root. The first package command requires installed workspace dependencies.
Run desktop and mobile checks sequentially.
The mobile command reuses the immediately preceding unchanged production build.
```bash
pnpm --dir apps install --frozen-lockfile
pnpm --dir apps/web exec vitest run lib/ui/control-sizing.test.tsx components/settings/settings-typography.test.ts
pnpm --dir apps/web run typecheck
pnpm --dir apps/web e2e:run --project chromium tests/layout/control-sizing.spec.ts
pnpm --dir apps/web e2e:run --no-build --project mobile-chrome tests/layout/mobile-control-sizing.spec.ts
```
Before completion, run ESLint on the exact changed TypeScript files from `apps/web`.
Record the expanded file list and command in Results.
Do not substitute class-string checks for browser geometry.
## Files likely touched
- `apps/packages/ui/src/control-sizing.tsx`
- `apps/packages/ui/src/button.tsx`
- `apps/packages/ui/src/input.tsx`
- `apps/packages/ui/src/select.tsx`
- `apps/packages/ui/src/input-group.tsx`
- `apps/web/components/settings/settings-control.ts`
- `apps/web/components/settings/settings-typography.tsx`
- `apps/web/components/combobox.tsx`
- `apps/web/components/workspaces/workspace-picker-content.tsx`
- `apps/web/lib/ui/control-sizing.test.tsx`
- `apps/web/e2e/helpers/control-sizing.ts`
- `apps/web/e2e/tests/layout/control-sizing.spec.ts`
- `apps/web/e2e/tests/layout/mobile-control-sizing.spec.ts`
The [inventory](sweep-inventory.md) section **Shared primitives** defines the remaining file scope.
## Dependencies
None.
## Risks
SelectTrigger data variants and InputGroup accessories need real CSS verification. Existing compact primitives must not receive a global touch expansion.
## Parallelism
`sequential`
## Inputs
- [Requirements](../../specs/ui/requirements/control-sizing.md)
- [System design](../../specs/ui/system-design/control-sizing.md)
- [Sweep inventory](sweep-inventory.md)
- Existing Start Task, settings typography, and mobile geometry tests.
## Results
Completed 2026-09-10.
- Red: the shared unit regression first observed the default Button without its
coarse-pointer classes; the managed desktop regression first measured 28px on
the coarse tablet instead of the required 44px.
- Green: `lib/ui/control-sizing.test.tsx` and settings typography coverage passed;
layout control sizing passed with 3 desktop and 2 mobile tests.
- The standard, compact, and icon classes are centralized in
`apps/packages/ui/src/control-sizing.tsx`; Button `sm` retains its original
compact semantics.
- Exact changed-file ESLint covered the full 200-file `apps/web` TypeScript set:
0 errors and 7 non-blocking warnings. The inventory records all candidate and
additional implementation files.
@@ -0,0 +1,119 @@
---
id: "02-task-controls"
title: "Task control sweep"
status: complete
wave: 2
depends_on: ["01-shared-sizes"]
plan: "plan.md"
requirements:
- REQ-UI-CONTROL-SIZING-001
acceptance_criteria:
- AC-UI-CONTROL-SIZING-001.1
- AC-UI-CONTROL-SIZING-001.2
- AC-UI-CONTROL-SIZING-001.3
- AC-UI-CONTROL-SIZING-001.4
- AC-UI-CONTROL-SIZING-001.5
- AC-UI-CONTROL-SIZING-001.6
- AC-UI-CONTROL-SIZING-001.7
- AC-UI-CONTROL-SIZING-001.8
- AC-UI-CONTROL-SIZING-001.9
- AC-UI-CONTROL-SIZING-001.10
system_design:
- ../../specs/ui/system-design/control-sizing.md
---
# Task 02: Task control sweep
## Summary
Normalize ordinary controls throughout task creation and task details. Repair completed-session and recovery actions while preserving compact chat chrome.
## In scope
- Disposition all Task surfaces candidates in sweep-inventory.md, including newly discovered callers.
- Repair session-stopped-banner, dynamic-route-recovery, session dialogs, action-message controls, file/preview toolbars, and task-level selectors.
- Keep Start Task at the reference desktop size and preserve its split action and phone composition.
- Inspect workflow disclosure row spacing separately from its already compact Move here action.
- Add task/control-sizing.spec.ts and task/mobile-control-sizing.spec.ts using the shared geometry helper.
## Out of scope
- Feature state, callbacks, permission changes, and persistence.
- Unrelated theme, typography, or navigation redesign.
## Acceptance
- New Agent, Resume, and Start fresh session render at 28px on desktop and retain touch minimums.
- Task controls have a recorded disposition, including correct compact and mobile-only exceptions.
- Completed/recovery actions, keyboard activation, busy states, and long labels retain their behavior.
## Regression first
Seed a completed session through existing isolated fixtures. Confirm that New Agent measures 44px and fails the 28px desktop assertion before the patch.
Use TDD for new helper logic and browser regressions.
Run the new regression before production edits and record the expected failure.
Rerun the same check after the correction.
## Verification
Run from the repository root. The first package command requires installed workspace dependencies.
Run desktop and mobile checks sequentially.
The mobile command reuses the immediately preceding unchanged production build.
```bash
pnpm --dir apps/web exec vitest run components/task/chat/session-stopped-banner.test.tsx components/task-create-dialog-footer.test.ts
pnpm --dir apps/web e2e:run --project chromium tests/task/control-sizing.spec.ts tests/layout/task-topbar-workflow-stepper.spec.ts
pnpm --dir apps/web e2e:run --no-build --project mobile-chrome tests/task/mobile-control-sizing.spec.ts
pnpm --dir apps/web run typecheck
```
Before completion, run ESLint on the exact changed TypeScript files from `apps/web`.
Record the expanded file list and command in Results.
Do not substitute class-string checks for browser geometry.
## Files likely touched
- `apps/web/components/task/chat/session-stopped-banner.tsx`
- `apps/web/components/task/chat/dynamic-route-recovery.tsx`
- `apps/web/components/task-create-dialog-footer.tsx`
- `apps/web/components/task/workflow-step-disclosure.tsx`
- `apps/web/components/task/chat/session-stopped-banner.test.tsx`
- `apps/web/components/task-create-dialog-footer.test.ts`
- `apps/web/e2e/tests/task/control-sizing.spec.ts`
- `apps/web/e2e/tests/task/mobile-control-sizing.spec.ts`
The [inventory](sweep-inventory.md) section **Task surfaces** defines the remaining file scope.
## Dependencies
01-shared-sizes
## Risks
Chat menus and selection rows can use button tags without being ordinary actions. Session completion fixtures must expose the actual banner.
## Parallelism
`sequential`
## Inputs
- [Requirements](../../specs/ui/requirements/control-sizing.md)
- [System design](../../specs/ui/system-design/control-sizing.md)
- [Sweep inventory](sweep-inventory.md)
- Existing Start Task, settings typography, and mobile geometry tests.
## Results
Completed 2026-09-10.
- Red: the completed-session regression measured the desktop New Agent action at
44px instead of 28px before the migration.
- Green: focused task unit coverage passed; task control sizing passed with 2
desktop and 1 mobile test, and the workflow-stepper suite passed with 2 desktop
tests covering fine-pointer and contained tablet touch navigation.
- Session recovery, task creation, action-message, preview, selector, and filter
controls now use the standard role or a recorded compact/content exception.
- The final typecheck and exact changed-file ESLint passed with 0 errors; the
completed inventory records the task-surface dispositions.
@@ -0,0 +1,122 @@
---
id: "03-settings-controls"
title: "Settings control sweep"
status: complete
wave: 3
depends_on: ["02-task-controls"]
plan: "plan.md"
requirements:
- REQ-UI-CONTROL-SIZING-001
acceptance_criteria:
- AC-UI-CONTROL-SIZING-001.1
- AC-UI-CONTROL-SIZING-001.2
- AC-UI-CONTROL-SIZING-001.3
- AC-UI-CONTROL-SIZING-001.4
- AC-UI-CONTROL-SIZING-001.5
- AC-UI-CONTROL-SIZING-001.6
- AC-UI-CONTROL-SIZING-001.7
- AC-UI-CONTROL-SIZING-001.8
- AC-UI-CONTROL-SIZING-001.9
- AC-UI-CONTROL-SIZING-001.10
system_design:
- ../../specs/ui/system-design/control-sizing.md
---
# Task 03: Settings control sweep
## Summary
Align ordinary settings fields, selectors, and actions across pages. Remove local desktop height overrides and preserve complete input/action groups.
## In scope
- Disposition all Settings surfaces candidates in sweep-inventory.md and all additional settings helper callers.
- Normalize Layouts New/Duplicate, workspace heading and placement pickers, and workflow section actions.
- Repair repository secrets, dynamic policy fields, storage actions/fields/confirmations, message queue fields, and executor page actions.
- Update desktop typography coverage from a lower bound to the actual size contract.
- Add settings/control-sizing.spec.ts and its mobile pair. Reuse existing Layouts and storage fixture patterns.
## Out of scope
- Feature state, callbacks, permission changes, and persistence.
- Unrelated theme, typography, or navigation redesign.
## Acceptance
- Equivalent settings action/field groups use 28px desktop height, including attached clear or reveal controls.
- The settings inventory has a disposition for every candidate and no unexplained desktop 32/36/40/44px ordinary controls.
- Phone and tablet paths retain touch targets, label readability, save coordination, and field values.
## Regression first
Assert 28px desktop dimensions for Layouts New/Duplicate and a repository secret input/select pair. Confirm the current 32px and 44px overrides fail.
Use TDD for new helper logic and browser regressions.
Run the new regression before production edits and record the expected failure.
Rerun the same check after the correction.
## Verification
Run from the repository root. The first package command requires installed workspace dependencies.
Run desktop and mobile checks sequentially.
The mobile command reuses the immediately preceding unchanged production build.
```bash
pnpm --dir apps/web exec vitest run components/settings/settings-typography.test.ts
pnpm --dir apps/web e2e:run --project chromium tests/settings/control-sizing.spec.ts tests/settings/settings-typography.spec.ts tests/settings/layout-profiles.spec.ts
pnpm --dir apps/web e2e:run --no-build --project mobile-chrome tests/settings/mobile-control-sizing.spec.ts tests/settings/mobile-settings-typography.spec.ts tests/settings/mobile-layout-profiles.spec.ts
pnpm --dir apps/web run typecheck
```
Before completion, run ESLint on the exact changed TypeScript files from `apps/web`.
Record the expanded file list and command in Results.
Do not substitute class-string checks for browser geometry.
## Files likely touched
- `apps/web/components/settings/layouts/layout-profile-list.tsx`
- `apps/web/components/settings/layouts/layout-settings.tsx`
- `apps/web/components/settings/workspaces/workspace-settings-shell.tsx`
- `apps/web/components/settings/workflow-section-actions.tsx`
- `apps/web/components/settings/repository-secret-bindings.tsx`
- `apps/web/components/settings/system/storage/storage-action-button.tsx`
- `apps/web/components/settings/system/storage/storage-policy-fields.tsx`
- `apps/web/components/settings/system/storage/storage-adoption-field.tsx`
- `apps/web/components/settings/system/storage/storage-confirmation-dialogs.tsx`
- `apps/web/e2e/tests/settings/settings-typography.spec.ts`
- `apps/web/e2e/tests/settings/control-sizing.spec.ts`
- `apps/web/e2e/tests/settings/mobile-control-sizing.spec.ts`
The [inventory](sweep-inventory.md) section **Settings surfaces** defines the remaining file scope.
## Dependencies
02-task-controls
## Risks
Storage and credential controls have attached icons and disabled tooltip wrappers. Shrinking only the field leaves oversized hit areas.
## Parallelism
`sequential`
## Inputs
- [Requirements](../../specs/ui/requirements/control-sizing.md)
- [System design](../../specs/ui/system-design/control-sizing.md)
- [Sweep inventory](sweep-inventory.md)
- Existing Start Task, settings typography, and mobile geometry tests.
## Results
Completed 2026-09-10.
- Red: the settings geometry regression measured Layouts actions at 32px and a
repository secret control at 44px instead of the 28px desktop standard.
- Green: settings control sizing, typography, and layout-profile coverage passed
with 10 desktop and 8 mobile tests; settings unit coverage also passed.
- Settings helpers now own complete standard dimensions, including attached
field actions, while mobile and coarse-pointer paths retain 44px targets.
- The final typecheck and exact changed-file ESLint passed with 0 errors; the
completed inventory records the settings-surface dispositions.
@@ -0,0 +1,124 @@
---
id: "04-application-controls"
title: "Application control sweep"
status: complete
wave: 4
depends_on: ["03-settings-controls"]
plan: "plan.md"
requirements:
- REQ-UI-CONTROL-SIZING-001
acceptance_criteria:
- AC-UI-CONTROL-SIZING-001.1
- AC-UI-CONTROL-SIZING-001.2
- AC-UI-CONTROL-SIZING-001.3
- AC-UI-CONTROL-SIZING-001.4
- AC-UI-CONTROL-SIZING-001.5
- AC-UI-CONTROL-SIZING-001.6
- AC-UI-CONTROL-SIZING-001.7
- AC-UI-CONTROL-SIZING-001.8
- AC-UI-CONTROL-SIZING-001.9
- AC-UI-CONTROL-SIZING-001.10
system_design:
- ../../specs/ui/system-design/control-sizing.md
---
# Task 04: Application control sweep
## Summary
Normalize remaining ordinary application controls and close the sweep inventory. Cover integrations, Office, navigation, and shared wrappers with representative rendered evidence.
## In scope
- Disposition all Other application surfaces and Office surfaces candidates in sweep-inventory.md.
- Inspect integration toolbars, saved-query dialogs, GitHub/GitLab actions, provider credentials, and application status alerts.
- Inspect Tasks list controls, Office fields, sidebar search, generic selectors, and shared confirmation actions.
- Extend layout/control-sizing.spec.ts and its mobile pair across the changed shared families.
- Repeat raw-control, helper, CSS, size-prop, inline-style, padding-only, and caller searches. Add every newly found defect to the inventory before closure.
## Out of scope
- Feature state, callbacks, permission changes, and persistence.
- Unrelated theme, typography, or navigation redesign.
## Acceptance
- Every candidate has a source-backed disposition or a completed change with relevant rendered evidence.
- Representative integration, Office, and navigation controls satisfy desktop sizes and touch minimums.
- The final inventory lists retained exceptions and any blocked checks without claiming a complete fix for unresolved defects.
## Regression first
Add a desktop regression for an application status alert or provider credential field with unconditional h-11. Confirm that the current control fails the standard-height assertion.
Use TDD for new helper logic and browser regressions.
Run the new regression before production edits and record the expected failure.
Rerun the same check after the correction.
## Verification
Run from the repository root. The first package command requires installed workspace dependencies.
Run desktop and mobile checks sequentially.
The mobile command reuses the immediately preceding unchanged production build.
```bash
pnpm --dir apps/web e2e:run --project chromium tests/layout/control-sizing.spec.ts
pnpm --dir apps/web e2e:run --no-build --project mobile-chrome tests/layout/mobile-control-sizing.spec.ts
pnpm --dir apps/web run typecheck
git diff --check
```
Before completion, run ESLint on the exact changed TypeScript files from `apps/web`.
Record the expanded file list and command in Results.
Do not substitute class-string checks for browser geometry.
## Files likely touched
- `apps/web/components/integrations/integration-list-toolbar.tsx`
- `apps/web/components/integrations/integration-save-query-dialog.tsx`
- `apps/web/components/github/github-pat-form.tsx`
- `apps/web/components/github/pr-merge-button.tsx`
- `apps/web/components/app-status-bar/backend-reload-required-alert.tsx`
- `apps/web/components/app-status-bar/agent-runtime-unavailable-alert.tsx`
- `apps/web/components/app-sidebar/sections/settings/settings-search.tsx`
- `apps/web/app/tasks/tasks-list-controls.tsx`
- `apps/web/app/tasks/tasks-pagination.tsx`
- `apps/web/app/office/projects/[id]/project-header.tsx`
- `apps/web/e2e/tests/layout/control-sizing.spec.ts`
- `apps/web/e2e/tests/layout/mobile-control-sizing.spec.ts`
- `docs/plans/control-sizing/sweep-inventory.md`
The [inventory](sweep-inventory.md) section **Other application surfaces and Office surfaces** defines the remaining file scope.
## Dependencies
03-settings-controls
## Risks
Provider and Office feature gates need isolated seed data. Shared integration components can affect several providers. Search hits are not automatically defects.
## Parallelism
`sequential`
## Inputs
- [Requirements](../../specs/ui/requirements/control-sizing.md)
- [System design](../../specs/ui/system-design/control-sizing.md)
- [Sweep inventory](sweep-inventory.md)
- Existing Start Task, settings typography, and mobile geometry tests.
## Results
Completed 2026-09-10.
- Green: representative application geometry passed with 3 desktop and 2 mobile
layout tests after migrating integration, Office, navigation, status, provider,
automation, and shared-wrapper controls.
- Follow-up helper, size-prop, and padding-only searches added 36 implementation
files to the inventory. Every candidate now has a changed, conforming,
touch-only, content-sized, or documented-exception disposition.
- Final harness/specification validation and `git diff --check` passed. Exact
changed-file ESLint covered 200 `apps/web` TypeScript files with 0 errors and
7 non-blocking warnings.
+2
View File
@@ -17,6 +17,7 @@ UI owns responsive behavior; other systems own behavior/state.
### Requirements
- [Control sizing](requirements/control-sizing.md)
- [ACP model summary](requirements/acp-model-configuration-summary.md)
- [ACP Shell Command Output](requirements/acp-shell-command-output.md)
- [Adaptive Kanban](requirements/adaptive-kanban.md)
@@ -151,6 +152,7 @@ UI owns responsive behavior; other systems own behavior/state.
- [WebSocket Connectivity Warning](requirements/ws-connectivity-warning.md)
### Design
- [Control sizing](system-design/control-sizing.md)
- [Adaptive Kanban](system-design/adaptive-kanban.md)
- [Clarification submit feedback](system-design/clarification-submit-feedback.md)
- [Dialog containment](system-design/dialog-content-containment.md)
@@ -0,0 +1,80 @@
---
status: active
system: ui
created: 2026-09-09
owners:
- Kandev frontend
---
# Control sizing requirements
## Overview
Equivalent controls must have consistent dimensions across Kandev.
The desktop Start Task dialog provides the reference density.
The UI system owns this reusable presentation contract across task, settings,
integration, and Office surfaces.
## Terminology
- **Standard control:** An ordinary action button or single-line field, including
a select trigger or combobox trigger.
- **Compact control:** An explicit inline action within dense application chrome.
- **Touch context:** A phone viewport below 768px or a device whose primary pointer is coarse.
- **Desktop context:** A viewport of at least 768px with a fine primary pointer.
- **Content surface:** A selection card, navigation row, menu option, or multiline field.
## Requirements
### REQ-UI-CONTROL-SIZING-001: Consistent control dimensions
**Intent:** Equivalent actions and fields retain consistent desktop density
without reducing touch usability.
#### Acceptance criteria
- **AC-UI-CONTROL-SIZING-001.1:** In desktop context, standard controls shall
have a height of 28px at the standard root font size.
- **AC-UI-CONTROL-SIZING-001.2:** In desktop context, explicit compact controls
shall have a height of 24px at the standard root font size.
- **AC-UI-CONTROL-SIZING-001.3:** Adjacent controls with the same size role
shall have equal heights, including attached picker, clear, and reveal actions.
- **AC-UI-CONTROL-SIZING-001.4:** In touch context, standard controls shall
provide an active target at least 44px high. Standalone icon actions shall
also provide an active target at least 44px wide.
- **AC-UI-CONTROL-SIZING-001.5:** When a viewport or pointer changes context,
shared controls shall use that context's dimensions without losing their values or focus.
- **AC-UI-CONTROL-SIZING-001.6:** Disabled and busy states shall retain the
control's size role. Primary styling shall not increase an ordinary action's height.
- **AC-UI-CONTROL-SIZING-001.7:** Long translated labels shall remain readable
without overlapping neighboring controls. Equivalent controls shall retain equal heights.
- **AC-UI-CONTROL-SIZING-001.8:** Keyboard and touch activation shall retain
existing actions, accessible names, focus behavior, and disabled behavior.
- **AC-UI-CONTROL-SIZING-001.9:** Text scaling shall remain available. Editable
touch fields shall retain the existing focus anti-zoom behavior.
- **AC-UI-CONTROL-SIZING-001.10:** Content surfaces and documented specialized
chrome shall retain their independent geometry. Their ordinary embedded actions
shall follow the standard or compact control role.
## Compatibility
The dimensions use CSS pixels at a 16px root font and scale with that root font.
Existing documented compact mobile chrome, such as MobilePillButton, retains
its explicit exception. This exception does not apply to ordinary actions.
The settings typography contract remains authoritative for text roles.
This requirement adds the shared height contract for its controls.
The compact workflow navigation contract retains its overlay and task-move behavior.
## Out of scope
- Changes to task state, permissions, APIs, persistence, or action semantics.
- A new theme, density preference, or user-facing configuration.
- Uniform heights for multiline editors, selection cards, and menu options.
- Geometry inside third-party editors, terminals, or external plugin applications.
## Related documents
- [System design](../system-design/control-sizing.md)
- [Settings typography](settings-typography.md)
- [Compact workflow navigation](compact-workflow-step-navigation.md)
@@ -0,0 +1,125 @@
---
status: current
system: ui
requirements:
- REQ-UI-CONTROL-SIZING-001
---
# Control sizing design
## Purpose and boundaries
The UI system owns shared control geometry. Feature components retain their
state, callbacks, permission checks, and translated labels.
This design centralizes size classes and removes ordinary per-page overrides.
It does not add a backend contract or a density preference.
## Requirement mapping
| Criteria under REQ-UI-CONTROL-SIZING-001 | Design section |
| --- | --- |
| .1, .2, .3, .6 | Shared sizes and caller migration |
| .4, .5, .9 | Responsive contract |
| .7, .8, .10 | Exceptions and interaction preservation |
## Current source
`apps/packages/ui/src/button.tsx` defines default, small, and large heights as
28px, 24px, and 32px. Input and default SelectTrigger use 28px.
SelectTrigger applies height through a data-size variant.
InputGroup also has a 28px shell and a separate multiline composition.
`apps/web/components/settings/settings-control.ts` applies a desktop minimum,
but larger caller heights still win. The settings helper does not reach every
settings control. Combobox and workspace triggers also accept local overrides.
The completed-session banner applies `min-h-11` with `size="sm"` on all
viewports. Layout actions use a desktop minimum of 32px. The workspace heading
picker uses 36px. These choices bypass the standard primitive dimensions.
## Shared sizes and caller migration
Add `apps/packages/ui/src/control-sizing.tsx` as the shared class source.
The existing package wildcard export supports this module without a new package.
It owns the standard and compact height classes, matching icon dimensions,
and adaptive touch classes. It contains no feature state or React hook.
Preserve the existing Button size API and its specialized `xs` and `lg` variants.
Use default Button size for ordinary actions and `sm` for deliberate compact
inline actions. Do not redefine `sm` globally as 28px.
Input retains its native HTML `size` attribute semantics and accepts
`controlSize="none"` when a fixed editor or file-browser field owns its own
geometry.
Reuse the shared size classes in Button, Input, SelectTrigger, and the single-line
InputGroup shell. Apply adaptive touch classes at shared application wrappers
and ordinary control call sites. Do not enlarge every primitive consumer
globally: InputGroup accessories and editor chrome have independent geometry.
Route settings-control helpers through this shared source. Keep typography
separate from dimensions. Migrate ordinary Combobox triggers and workspace
triggers through the same source. Preserve Combobox search, selection, and
portal behavior. Audit its `touchTarget` callers before replacing local dimensions.
Remove conflicting caller `h-*`, `min-h-*`, `size-*`, and data-size height
overrides. Inspect parent flex stretching and attached action widths.
An attached clear or reveal button must not retain a taller absolute hitbox.
Change complete control groups together so fields and buttons remain aligned.
## Responsive contract
Fine-pointer dimensions form the base classes. Adaptive classes apply the touch
minimum below 768px or for `pointer: coarse`. An `any-pointer` match alone does
not select large controls on a mouse-driven hybrid laptop.
The existing `any-pointer: coarse` input font rule remains unchanged.
The 768px condition controls sizing, not overlay composition.
Existing 640px Radix menu treatment remains intact.
CSS adapts geometry without remounting fields or resetting their state.
The Start Task dialog retains its split desktop action and stacked phone actions.
The completed-session banner retains its existing stacked phone composition.
The nearest mobile exemplars are Start Task's footer and settings-control helpers.
Settings actions continue to wrap within their existing page scroll owner.
Workflow navigation retains its Popover and coarse-pointer Drawer split.
The existing drawer owns scrolling and safe-area clearance.
## Exceptions and interaction preservation
The migration classifies each candidate as standard, compact, touch-only,
content-sized, or a documented specialized exception.
Selection cards, full navigation rows, multiline inputs, mobile pills, editor
controls, and embedded third-party surfaces require inspection before any change.
An HTML button tag alone does not identify an ordinary action.
Preserve tooltip wrappers, focus rings, semantic button types, disabled state,
busy labels, translated text, and event handlers.
For long labels, allow horizontal layout or group wrapping before clipping text.
Do not reduce font sizes to fit a mismatched control height.
If a button deliberately supports multiline content, classify it as content-sized.
## Verification
Browser geometry is the authority for the CSS cascade. At a 16px root font,
desktop standard and compact controls use 28px and 24px with a 1px tolerance.
Tests also compare adjacent control heights so wrong equal defaults cannot hide
an absolute-size regression. Touch tests assert minimum active dimensions.
Representative application tests cover Start Task, completed and recovery
banners, Layouts, workspace selectors, workflow actions, repository secrets,
storage fields, and shared integration pickers. Include desktop fine pointers,
phone widths of 390px and 700px, and a coarse-pointer tablet at 900px.
Cover disabled, busy, long-label, and keyboard/touch activation paths.
The initial source inventory is a candidate list, not proof of coverage.
Implementation records a disposition for every candidate file and repeats
searches for named helpers, CSS overrides, padding-only sizes, and size props.
Remaining exceptions need a reason and a source or rendered reference.
## Rationale
The accepted 28px size matches Start Task and existing default primitives.
A global button-height override also resizes cards and specialized chrome.
Changing Button's small variant alters unrelated dense controls.
Shared size classes plus a caller sweep preserve those distinctions.
This design records the rationale without a separate ADR.