From 5be05726b93233e3d75892559e64bdf7dfd0ee94 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Salavisa?= Date: Sat, 1 Aug 2026 17:31:30 +0100 Subject: [PATCH] chore: remove dead system.error websocket contract (#2066) Co-authored-by: Kandev Agent Co-authored-by: Claude Opus 5 (1M context) --- apps/packages/types/src/backend.ts | 7 ------- apps/web/lib/types/backend.ts | 6 ------ apps/web/lib/ws/handlers/system-events.ts | 3 --- 3 files changed, 16 deletions(-) diff --git a/apps/packages/types/src/backend.ts b/apps/packages/types/src/backend.ts index 1da1e846d4..a25ee543aa 100644 --- a/apps/packages/types/src/backend.ts +++ b/apps/packages/types/src/backend.ts @@ -7,7 +7,6 @@ export type BackendMessageType = | "agent.updated" | "terminal.output" | "diff.update" - | "system.error" | "workspace.created" | "workspace.updated" | "workspace.deleted" @@ -75,11 +74,6 @@ export type DiffUpdatePayload = { }>; }; -export type SystemErrorPayload = { - message: string; - code?: string; -}; - export type TaskSessionNotificationPayload = { task_id: string; session_id: string; @@ -133,7 +127,6 @@ export type BackendMessageMap = { "agent.updated": BackendMessage<"agent.updated", AgentUpdatePayload>; "terminal.output": BackendMessage<"terminal.output", TerminalOutputPayload>; "diff.update": BackendMessage<"diff.update", DiffUpdatePayload>; - "system.error": BackendMessage<"system.error", SystemErrorPayload>; "workspace.created": BackendMessage<"workspace.created", WorkspacePayload>; "workspace.updated": BackendMessage<"workspace.updated", WorkspacePayload>; "workspace.deleted": BackendMessage<"workspace.deleted", WorkspacePayload>; diff --git a/apps/web/lib/types/backend.ts b/apps/web/lib/types/backend.ts index 3b76f008af..336281ff39 100644 --- a/apps/web/lib/types/backend.ts +++ b/apps/web/lib/types/backend.ts @@ -172,11 +172,6 @@ export type DiffUpdatePayload = { }>; }; -export type SystemErrorPayload = { - message: string; - code?: string; -}; - export type UpdateAvailablePayload = { version: string; url?: string; @@ -510,7 +505,6 @@ export type BackendMessageMap = OfficeBackendMessageMap & "terminal.output": BackendMessage<"terminal.output", TerminalOutputPayload>; "diff.update": BackendMessage<"diff.update", DiffUpdatePayload>; "session.git.event": BackendMessage<"session.git.event", GitEventPayload>; - "system.error": BackendMessage<"system.error", SystemErrorPayload>; "system.job.update": BackendMessage<"system.job.update", import("./system").SystemJob>; "system.metrics.updated": BackendMessage<"system.metrics.updated", SystemMetricsSnapshot>; "system.update_available": BackendMessage<"system.update_available", UpdateAvailablePayload>; diff --git a/apps/web/lib/ws/handlers/system-events.ts b/apps/web/lib/ws/handlers/system-events.ts index e49ad7f484..a59bbf98e1 100644 --- a/apps/web/lib/ws/handlers/system-events.ts +++ b/apps/web/lib/ws/handlers/system-events.ts @@ -4,9 +4,6 @@ import type { WsHandlers } from "@/lib/ws/handlers/types"; export function registerSystemEventsHandlers(store: StoreApi): WsHandlers { return { - "system.error": () => { - // TODO: surface as toast/notification once UI is ready. - }, "system.job.update": (message) => { // The WS payload is the full SystemJob row published by the backend // jobs tracker (see internal/system/jobs). Upsert by id so the