diff --git a/apps/web/components/task/task-classify.ts b/apps/web/components/task/task-classify.ts index c8b9505822..7862c4371b 100644 --- a/apps/web/components/task/task-classify.ts +++ b/apps/web/components/task/task-classify.ts @@ -25,10 +25,11 @@ export function classifyTask( if (TASK_STATE_IN_PROGRESS.has(taskState)) return "in_progress"; return "backlog"; } - // STARTING is a transient session state (e.g. during auto-resume after a - // backend restart). Defer to the workflow task state so a task in REVIEW - // does not flicker out of the review bucket while the agent reattaches. - if (sessionState === "STARTING" && taskState) { + // CREATED/STARTING are transient session states while the agent process is + // booting or reattaching. Defer to the workflow task state so an + // IN_PROGRESS task keeps showing activity, while a REVIEW task does not + // flicker out of the review bucket during auto-resume. + if ((sessionState === "CREATED" || sessionState === "STARTING") && taskState) { if (TASK_STATE_REVIEW.has(taskState)) return "review"; if (TASK_STATE_IN_PROGRESS.has(taskState)) return "in_progress"; return "backlog"; diff --git a/apps/web/components/task/task-item.test.tsx b/apps/web/components/task/task-item.test.tsx index 0c39a763e1..de3926b93e 100644 --- a/apps/web/components/task/task-item.test.tsx +++ b/apps/web/components/task/task-item.test.tsx @@ -94,6 +94,29 @@ describe("TaskItem status icon", () => { expectPreparingSpinner(); }); + it("does not show a spinner for a created task waiting for manual start", () => { + renderTaskItem({ state: "CREATED" }); + + expect(screen.queryByTestId(RUNNING_ICON_TEST_ID)).toBeNull(); + expect(screen.queryByTestId("task-state-backlog")).not.toBeNull(); + }); + + it("does not show a spinner for a created task with a prepared CREATED session", () => { + renderTaskItem({ state: "CREATED", sessionState: "CREATED" }); + + expect(screen.queryByTestId(RUNNING_ICON_TEST_ID)).toBeNull(); + expect(screen.queryByTestId("task-state-backlog")).not.toBeNull(); + }); + + it("shows a running spinner while an in-progress session is created but not started", () => { + renderTaskItem({ state: "IN_PROGRESS", sessionState: "CREATED" }); + + const icon = screen.getByTestId(RUNNING_ICON_TEST_ID); + expect(icon.getAttribute("data-loading-phase")).toBe("running"); + expect(icon.classList.contains("text-yellow-500")).toBe(true); + expect(icon.classList.contains(SPIN_CLASS)).toBe(true); + }); + it("does not show preparing spinner for a review task whose session transiently hits STARTING", () => { renderTaskItem({ state: "REVIEW", sessionState: "STARTING" }); diff --git a/apps/web/components/task/task-switcher.test.ts b/apps/web/components/task/task-switcher.test.ts index 1eb87d2053..dc8d9f929a 100644 --- a/apps/web/components/task/task-switcher.test.ts +++ b/apps/web/components/task/task-switcher.test.ts @@ -21,6 +21,14 @@ describe("classifyTask", () => { it("buckets STARTING with REVIEW task state as review", () => { expect(classifyTask("STARTING", "REVIEW")).toBe("review"); }); + + it("uses task state while a CREATED session is booting", () => { + expect(classifyTask("CREATED", "IN_PROGRESS")).toBe("in_progress"); + expect(classifyTask("CREATED", "SCHEDULING")).toBe("in_progress"); + expect(classifyTask("CREATED", "REVIEW")).toBe("review"); + expect(classifyTask("CREATED", "CREATED")).toBe("backlog"); + expect(classifyTask("CREATED", "TODO")).toBe("backlog"); + }); }); describe("applySort state (regression: silent resume reorder)", () => {