fix(quick-chat): restore persisted tabs after task reload (#1703)

This commit is contained in:
Carlos Florêncio
2026-07-15 17:40:34 +01:00
committed by GitHub
parent e067e7a1f6
commit 31157142a2
16 changed files with 470 additions and 131 deletions
+42 -20
View File
@@ -1,5 +1,5 @@
---
status: draft
status: shipped
created: 2026-07-02
owner: José Almeida
---
@@ -7,6 +7,7 @@ owner: José Almeida
# Quick Chat Persistence & Expiration
## Why
A user reported her quick chats "disappearing much faster." Quick chats are
ephemeral tasks whose open-tab list lives only in the in-memory frontend store,
so a page reload drops every tab even though the underlying task, session, and
@@ -16,8 +17,12 @@ recent quick chats to survive a reload, and the system needs a bound so
abandoned quick chats don't accumulate forever.
## What
- Open quick-chat tabs SHALL be restored after a full page reload, reconstructed
from backend state rather than client-only memory.
- Hydration SHALL resolve the workspace represented by the current route. On `/t/:id`
and `/office/tasks/:id` task-detail routes, the task's workspace is authoritative over
a stale active-workspace cookie or user setting.
- A quick chat that has been idle longer than the retention window SHALL be
deleted automatically (task row, its sessions, and its workspace directory),
the same as an explicit close.
@@ -33,6 +38,7 @@ abandoned quick chats don't accumulate forever.
SHALL NOT expire, regardless of how old it is.
## Data model
No new tables. This feature operates on existing `tasks` and `task_sessions`
rows. A **quick chat** is precisely the set of tasks matching:
@@ -57,17 +63,21 @@ guard. The `origin` guard distinguishes user-started quick chats (`origin =
last_activity = MAX(task.updated_at, MAX(session.updated_at) over its task_sessions)
```
Using the greater of the task row and its newest session row makes the metric
robust to whichever row a message/turn bumps. A quick chat expires when
`now - last_activity > 7 days`.
Message and turn writes update their own rows only. A dispatched prompt changes
the quick-chat session's runtime state, which updates `task_sessions.updated_at`;
the associated task runtime-state transition can also update `tasks.updated_at`.
Using the greater of the task row and its newest session row therefore captures
the persisted activity written by the shipped prompt lifecycle. A quick chat
expires when `now - last_activity > 7 days`.
## API surface
- **Hydration (read):** reuse the existing workspace task listing rather than a
new endpoint. The frontend fetches quick chats via
new endpoint. The backend boot payload fetches quick chats via
`ListTasksByWorkspace(workspaceId, workflowID="", …, onlyEphemeral=true,
excludeConfig=true)` and filters out `origin == "automation_run"`, then
rebuilds the `quickChat.sessions` store slice (one tab per returned task, in
most-recently-active-first order). Each restored tab needs
creation order). Each restored tab needs
`{ sessionId, workspaceId, agentProfileId }`, all resolvable from the task and
its primary session. The persisted display name is already available via
`getStoredQuickChatName` / `setStoredQuickChatName`.
@@ -78,20 +88,23 @@ robust to whichever row a message/turn bumps. A quick chat expires when
client through the existing `task.deleted` WS handler.
## State machine
A quick chat task is created `active`, and reaches a terminal `deleted` state via
one of these triggers (this feature adds only the last one):
| Trigger | Actor | Existing? |
|---|---|---|
| User closes a tab (confirm) | user | yes (`use-quick-chat-modal.ts` `handleConfirmClose`) |
| Rapid re-pick supersedes an in-flight start | frontend | yes (`useAgentSelection` orphan cleanup) |
| Agent profile deleted | user | yes (`DeleteEphemeralTasksByAgentProfile`) |
| **Idle longer than retention window** | **background sweep** | **new** |
| Trigger | Actor | Existing? |
| ------------------------------------------- | -------------------- | ---------------------------------------------------- |
| User closes a tab (confirm) | user | yes (`use-quick-chat-modal.ts` `handleConfirmClose`) |
| Rapid re-pick supersedes an in-flight start | frontend | yes (`useAgentSelection` orphan cleanup) |
| Agent profile deleted | user | yes (`DeleteEphemeralTasksByAgentProfile`) |
| **Idle longer than retention window** | **background sweep** | **new** |
All four converge on `Service.DeleteTask`, so directory cleanup and event
publishing are identical.
All triggers use the existing quick-chat deletion cleanup and event path.
Expiration first rechecks the expiry predicate at delete time, then performs
the same directory cleanup and event publishing.
## Failure modes
- **Last-activity query fails / returns error:** the sweep fails closed — it
deletes nothing that pass and logs a warning. A transient DB error must never
cause an over-broad delete.
@@ -109,6 +122,7 @@ publishing are identical.
`now`; it does not assume monotonic wall clock beyond the 7-day granularity.
## Persistence guarantees
- **Survives reload:** open quick-chat tabs (restored from backend), quick-chat
task rows, sessions, and workspace directories — until they expire or are
closed.
@@ -125,9 +139,13 @@ publishing are identical.
a day of the window elapsing.
## Scenarios
- **GIVEN** an open quick chat with one or more tabs, **WHEN** the user reloads
the page, **THEN** the same tabs reappear, ordered most-recently-active first,
the page, **THEN** the same tabs reappear in creation order,
each showing its prior chat history and persisted name.
- **GIVEN** Quick Chats created from a task whose workspace differs from the
persisted active-workspace setting, **WHEN** the user reloads the task route,
**THEN** the task workspace's tabs restore without tabs from another workspace.
- **GIVEN** a quick-chat task whose `last_activity` is 8 days ago, **WHEN** the
expiration sweep runs, **THEN** the task, its sessions, and its workspace
directory are deleted, a `task.deleted` event is published, and the tab
@@ -151,6 +169,7 @@ publishing are identical.
iteration).
## Out of scope
- A user-configurable retention window (per-workspace or global setting). Ships
as a hardcoded 7-day constant; revisit only if requested.
- A hard count cap on number of quick chats (idle TTL only). If clutter becomes
@@ -161,8 +180,11 @@ publishing are identical.
the existing close behavior.
- Changing config-mode chat, automation-run, or kanban/office task lifecycles.
## Open questions
- Does a message/turn in a quick chat currently bump `tasks.updated_at`, or only
`task_sessions.updated_at` / turn rows? The `MAX(task, session)` definition is
chosen to be correct either way, but the implementation should confirm which
row actually moves so the sweep query reads the right column(s).
## Verified implementation
- Raw message and turn persistence does not update the parent task or session.
- Prompt dispatch and completion transition the quick-chat session state and
update `task_sessions.updated_at`.
- A quick-chat task runtime-state transition can also update `tasks.updated_at`.
- The expiration query reads both parent timestamps and excludes `RUNNING` and
`IDLE` sessions, so active or recently completed prompt lifecycles are retained.
@@ -36,6 +36,9 @@ context without changing their checked-out branches or creating a kanban task.
footer uses that same continuous surface, and the new chat action appears immediately after the
last chat tab.
- Quick-chat tabs remain in creation order across reloads; later activity does not reorder them.
- On `/t/:id` and `/office/tasks/:id` task-detail routes, Quick Chat hydration follows the
task's workspace even when the persisted active-workspace cookie or user setting points
elsewhere. Tabs from other workspaces are not rendered or selected as fallbacks.
- Hovering either resize target highlights the dialog's outer border, not an inset line.
- The setup flow supports desktop and mobile layouts without horizontal page scrolling or
hover-only actions. Mobile quick chat remains full-screen and does not expose resize handles.