fix: support unsigned desktop releases (#1520)

This commit is contained in:
Carlos Florêncio
2026-06-28 19:13:16 +01:00
committed by GitHub
parent 5c4fab2bd2
commit 14a5fb2c7f
11 changed files with 109 additions and 49 deletions
+25 -4
View File
@@ -252,21 +252,39 @@ describe("release desktop artifacts", () => {
tauri_bundles: deb,rpm`);
});
it("fails public macOS and Windows desktop builds closed when signing secrets are absent", () => {
it("supports unsigned desktop releases separately from validation-only builds", () => {
const workflow = releaseWorkflow();
const signingDocs = readRepoFile("docs/desktop-tauri-signing.md");
const tauriConfig = readRepoFile("apps/desktop/src-tauri/tauri.conf.json");
const windowsSignScript = readRepoFile("apps/desktop/src-tauri/windows-sign.ps1");
expect(workflow).toContain("allow_unsigned_desktop");
expect(workflow).toContain("Unsigned desktop artifacts are internal validation only");
expect(workflow).toContain("desktop_validation_only");
expect(workflow).toContain("ref: ${{ needs.prepare.outputs.ref }}");
expect(workflow).toContain("persist-credentials: false");
expect(workflow).toContain("Unsigned desktop validation summary");
expect(workflow).toContain("Desktop validation summary");
expect(workflow).toContain("No release PR, tag, GitHub release, public container tags");
expect(workflow).toContain("if: ${{ !inputs.dry_run && !inputs.allow_unsigned_desktop }}");
expect(workflow).toContain("if: ${{ !inputs.dry_run && !inputs.desktop_validation_only }}");
expect(workflow).toContain('if [ "$DESKTOP_VALIDATION_ONLY" = "true" ]; then');
expect(workflow).toContain(
"Allow unsigned macOS/Windows desktop artifacts; still publishes unless validation-only is checked",
);
expect(workflow).toContain("Add unsigned desktop warning to release notes");
expect(workflow).toContain(
"macOS and Windows desktop installers in this release are unsigned.",
);
expect(workflow).not.toMatch(
/if \[ "\$ALLOW_UNSIGNED_DESKTOP" = "true" \]; then\r?\n\s*echo "ref=\$CURRENT_REF"/,
);
expect(workflow).toContain("docker-amd64:");
expect(workflow).toContain("docker-universal-manifest:");
expect(workflow).toContain('if [ "$ALLOW_UNSIGNED_DESKTOP" = "true" ]; then');
expect(workflow).toContain("unset APPLE_CERTIFICATE");
expect(workflow).toContain("unset APPLE_ID");
expect(workflow).toContain("unset WINDOWS_CERTIFICATE");
expect(workflow).toContain("unset WINDOWS_CERTIFICATE_PASSWORD");
expect(workflow).toContain("unset WINDOWS_TIMESTAMP_URL");
expect(workflow).toContain("unset WINDOWS_SIGNTOOL_PATH");
for (const key of [
"APPLE_CERTIFICATE",
@@ -303,9 +321,12 @@ describe("release desktop artifacts", () => {
expect(tauriConfig).toContain("windows-sign.ps1");
expect(tauriConfig).not.toContain('"csp": null');
expect(windowsSignScript).toContain('"https://timestamp.digicert.com"');
expect(windowsSignScript).toContain("Skipping Windows signing for unsigned desktop artifact");
expect(windowsSignScript).toContain("Remove-Item -LiteralPath $certificatePath");
expect(signingDocs).toContain("Public recommended desktop releases require signing");
expect(signingDocs).toContain("allow_unsigned_desktop");
expect(signingDocs).toContain("desktop_validation_only");
expect(signingDocs).toContain("publishes the normal release outputs");
expect(signingDocs).toContain("does not publish a GitHub release");
expect(signingDocs).toContain("public container tags");
expect(signingDocs).toContain("Ubuntu 22.04");